feat: hisat3n/align #9718
Open
feat: hisat3n/align #9718
+514
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashehu
reviewed
Jan 20, 2026
| then { | ||
| assertAll( | ||
| { assert process.success }, | ||
| { assert snapshot(process.out.summary).match("se_summary") }, |
Contributor
There was a problem hiding this comment.
according to the nf-core guidline all output need to be captured and the sam output seems to be missing here (https://nvnieuwk.github.io/nft-bam/latest/ might be helpful if it is too unstable)
mashehu
reviewed
Jan 20, 2026
| channels: | ||
| - conda-forge | ||
| - bioconda | ||
| - nodefaults |
Contributor
There was a problem hiding this comment.
I don't think this is needed
Suggested change
| - nodefaults |
Contributor
Author
There was a problem hiding this comment.
Here is some additional context for nodefaults:
https://blog.fulcrumgenomics.com/p/anaconda-licensing-changes and #8847
It is not strictly necessary but may be a nice to have
…consistent with hisat3n/build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #9673. Adds
hisat3n/alignfor nucleotide conversion read alignment.topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda