Skip to content

Conversation

@ammaraziz
Copy link
Contributor

@ammaraziz ammaraziz commented Jan 19, 2026

PR checklist

Closes #9647 and #9646

  1. Multiple uses of seqkit replace module fail due to output/input name conflicts #9647 fix by staging the input as "raw.fasta" so that subsequent uses don't fail.
  2. seqkit replace incorrectly uses the '-i' flag #9646 remove -i flag incorrectly used as input, -i for ignoring case.

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally catch cases where the input file can be the same as the output file in this way:
https://github.com/search?q=repo%3Anf-core%2Fmodules%20disambig&type=code
Which can be combined with setting a default value for prefix that isn't just meta.id, e.g.
def prefix = task.ext.prefix ?: "${meta.id}_replaced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple uses of seqkit replace module fail due to output/input name conflicts

2 participants