-
Notifications
You must be signed in to change notification settings - Fork 954
Add tmb module #9660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add tmb module #9660
Conversation
|
Even though I run |
I think you need to run it with the dev version |
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
SPPearce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've had a discussion in the past about including small test files like these yml files in the tests folder; personally I think it is a good idea but it was not in consensus.
You can make this kind of file on the fly inside the nf-test though, like this: https://github.com/nf-core/modules/blob/master/modules/nf-core/ngscheckmate/ncm/tests/main.nf.test#L58
I'm not sure I completely understand, but the creation of the yml files are not created by another module and that is why I've included them on the tests folder. |
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Removed duplicate 'burden' keyword from meta.yml.
SPPearce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The consensus seems to be not to allow these kind of files still.
You can create them inside nf-test though, like:
setup {
new File("${launchDir}/test.yaml").text = """
freq: "AF"
depth: "DP"
altDepth: "AD"
maxVaf: "1"
""".stripIndent()
}
//...
process {
"""
input[N] = file("${launchDir}/test.yaml")
"""
}
That'll work for the haplotc.yml, but the snpeff.yml is quite large.
The other option is to add them to the test-datasets repository, where all the other test data files live.

PR checklist
Module for the tmb tool
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda