Skip to content

Conversation

@eduard-watchmaker
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@eduard-watchmaker eduard-watchmaker requested review from a team as code owners October 30, 2025 20:50
Copy link
Contributor

@Joon-Klaps Joon-Klaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in nf-test.config is something that needs to be double checked.

@eduard-watchmaker
Copy link
Contributor Author

The changes in nf-test.config is something that needs to be double checked.

Removed and added to specific subworkflow tests directives!

Copy link
Contributor

@Joon-Klaps Joon-Klaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, quite a few things I should have spotted in the first round.

@famosab
Copy link
Contributor

famosab commented Nov 18, 2025

Ah yes the bwa/index issue I suspect. See github.com//issues/9230 for the ongoing discussion.

@eduard-watchmaker
Copy link
Contributor Author

Ah yes the bwa/index issue I suspect. See github.com//issues/9230 for the ongoing discussion.

I assume these tests were running on the original version of fq2bam? Unsure why they are not working now with the samew bwa mem issue.

@eduard-watchmaker
Copy link
Contributor Author

Very unsure about what is going on with the singularity / apptainer profile here, any thoughts @famosab @Joon-Klaps ?

@eduard-watchmaker
Copy link
Contributor Author

@nf-core-bot update gpu snaphost path: subworkflows/nf-core/fastq_align_dedup_bwamem/tests/gpu.nf.test

@eduard-watchmaker
Copy link
Contributor Author

@nf-core-bot fix linting

@eduard-watchmaker
Copy link
Contributor Author

@nf-core-bot fix linting

1 similar comment
@eduard-watchmaker
Copy link
Contributor Author

@nf-core-bot fix linting

@github-actions
Copy link

Nothing for me to do here! 🤷
This is probably because the linting errors come from nf-core lint and have to be fixed manually (or with nf-core lint --fix).

@awgymer awgymer enabled auto-merge December 12, 2025 09:37
@awgymer awgymer disabled auto-merge December 12, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants