-
Notifications
You must be signed in to change notification settings - Fork 946
Add fq2bam fq align dd bwamem #9309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…dules into add_fq2bam_fq_align_dd_bwamem
Joon-Klaps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in nf-test.config is something that needs to be double checked.
…dules into add_fq2bam_fq_align_dd_bwamem
Removed and added to specific subworkflow tests directives! |
Joon-Klaps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, quite a few things I should have spotted in the first round.
subworkflows/nf-core/fastq_align_dedup_bwamem/tests/gpu.nf.test
Outdated
Show resolved
Hide resolved
subworkflows/nf-core/fastq_align_dedup_bwamem/tests/gpu.nf.test
Outdated
Show resolved
Hide resolved
subworkflows/nf-core/fastq_align_dedup_bwamem/tests/gpu.nf.test
Outdated
Show resolved
Hide resolved
subworkflows/nf-core/fastq_align_dedup_bwamem/tests/gpu.nf.test
Outdated
Show resolved
Hide resolved
subworkflows/nf-core/fastq_align_dedup_bwamem/tests/gpu.nf.test
Outdated
Show resolved
Hide resolved
subworkflows/nf-core/fastq_align_dedup_bwamem/tests/main.nf.test
Outdated
Show resolved
Hide resolved
…dules into add_fq2bam_fq_align_dd_bwamem
|
Ah yes the bwa/index issue I suspect. See github.com//issues/9230 for the ongoing discussion. |
I assume these tests were running on the original version of fq2bam? Unsure why they are not working now with the samew bwa mem issue. |
|
Very unsure about what is going on with the singularity / apptainer profile here, any thoughts @famosab @Joon-Klaps ? |
…dules into add_fq2bam_fq_align_dd_bwamem
|
@nf-core-bot update gpu snaphost path: subworkflows/nf-core/fastq_align_dedup_bwamem/tests/gpu.nf.test |
|
@nf-core-bot fix linting |
|
@nf-core-bot fix linting |
1 similar comment
|
@nf-core-bot fix linting |
|
Nothing for me to do here! 🤷 |
PR checklist
Closes #XXX
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda