Skip to content

octopusv bump versions + associated logic and test updates - #12503

Open
manascripts wants to merge 2 commits into
nf-core:masterfrom
manascripts:octopusv-bump-version
Open

octopusv bump versions + associated logic and test updates#12503
manascripts wants to merge 2 commits into
nf-core:masterfrom
manascripts:octopusv-bump-version

Conversation

@manascripts

Copy link
Copy Markdown
Member

This pull request upgrades the octopusv dependency to version 0.4.1 across all related modules and updates container references accordingly.

  • octopusv/stat now supports dual invocation for new JSON and legacy TXT output along with the HTML report.
  • octopusv/plot now supports both JSON and TXT input for statistics, makes SVG outputs optional, and adds corresponding tests for the new input type.
  • Test snapshots, tests and corresponding meta.yml files are updated to reflect the new version and i/o changes.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@erikrikarddaniel erikrikarddaniel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants