updated module: xengsort/index - #12494
Open
LeonHornich wants to merge 13 commits into
Open
Conversation
SPPearce
reviewed
Aug 3, 2026
Comment on lines
+37
to
+42
| { assert path(process.out.hash[0][1]).exists() }, | ||
| { assert path(process.out.info[0][1]).exists() }, | ||
| { assert snapshot( | ||
| path(process.out.hash[0][1]).getFileName().toString(), | ||
| path(process.out.info[0][1]).getFileName().toString(), | ||
| process.out.findAll { key, val -> key.startsWith("versions") } |
Contributor
There was a problem hiding this comment.
This could probably all be sanitizeOutput(process.out, unstableKeys: ["hash", "info"])
Comment on lines
+28
to
+40
| def subtables = Math.max([(cpus / 2) as int - 1, cpus - 3, 19].min(), 1) | ||
| if ((subtables % 2) == 0) { | ||
| subtables += 1 | ||
| } | ||
|
|
||
| def read_threads = Math.ceil(subtables / 10) as int | ||
|
|
||
| def split_threads = 2 * read_threads | ||
|
|
||
| if ((subtables + read_threads + split_threads) >= cpus) { | ||
| read_threads = 1 | ||
| split_threads = 2 | ||
| } |
Contributor
There was a problem hiding this comment.
Where is all this coming from?
Contributor
Author
| description: The expression to obtain the version of the tool | ||
|
|
||
| authors: | ||
| - "@diegomscoelho" |
Contributor
There was a problem hiding this comment.
Still was the original author. You can add yourself though.
LeonHornich
force-pushed
the
xengsort_index
branch
from
August 3, 2026 08:55
03fc12d to
412de2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated existing
xengsort/indexmodule with the following changes:--bisulfitemodePR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda