Skip to content

Deep mased imp modules - #12472

Open
SkyLexS wants to merge 18 commits into
nf-core:masterfrom
SkyLexS:deep_mased_imp_modules
Open

Deep mased imp modules#12472
SkyLexS wants to merge 18 commits into
nf-core:masterfrom
SkyLexS:deep_mased_imp_modules

Conversation

@SkyLexS

@SkyLexS SkyLexS commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

PR checklist

Closes #XXX

  • Made DeepMAsED opt-in by default, merged the redundant skip flags into one (skip_deepmased), and renamed deepmased_cpu_only to deepmased_use_gpu (also opt-in). Fixed the assembly filter to select by assembler instead of sr_platform, correctly excluding hybrid/long-read assemblies, and decoupled DeepMAsED from skip_binning like ALE. On the modules: added the process_gpu label to DEEPMASED_PREDICT and fixed DEEPMASED_FEATURES' output (plus stub) to accept gzipped files. Docs updated accordingly.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

SkyLexS and others added 12 commits May 13, 2026 14:02
…alidation

Added split output channels, corrected naming, collision detection, and explicit versioning. Chose versions.yml over topic: versions for better pipeline compatibility and simpler maintenance. Test snapshots are auto-generated via nf-test to keep the format clean. Meta descriptions stayed detailed to help downstream users understand the outputs. Everything validated: lint 43/44, pre-commit all green, tests passing. Ready for integration.
output:
tuple val(meta), path("*_feature_file_paths.tsv"), emit: feature_table
tuple val(meta), path("*_feats.tsv"), emit: feature_files
tuple val(meta), path("*_feats.tsv{,.gz}"), emit: feature_files

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the meta output block to match this change.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was an unexpected conflict and I resolved it poorly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants