Migrate narfmap/hashtable to topic channels - #12445
Conversation
Generated by Codex
Generated by Codex
Generated by Codex
Generated by Codex
Generated by Codex
Generated by Codex
Generated by Codex
Generated by Codex
Generated by Codex
Generated by Codex
Generated by Codex
Generated by Codex
Generated by Codex
Generated by Codex
| type: string | ||
| description: The name of the tool | ||
| - samtools version | sed '1!d;s/.* //': | ||
| - samtools version | sed '1!d;s/.* //;s/^1[.]23[.]1\$/1.23/': |
LouisLeNezet
left a comment
There was a problem hiding this comment.
Hi @xHaMMaDy,
Would you have some time to finish this PR ?
| { assert snapshot( | ||
| process.out.bam, | ||
| process.out.bam.collect { meta, bamFile -> [meta, file(bamFile).name, file(bamFile).exists(), file(bamFile).size() > 0] }, | ||
| file(process.out.log[0][1]).readLines().findAll { it.startsWith("decompHash") }, |
There was a problem hiding this comment.
This line should be as a separate assertion outside the snapshot.
There was a problem hiding this comment.
I meant
assertAll (
{ assert process.success },
{ assert file(process.out.log[0][1]).readLines().findAll { it.startsWith("decompHash") } },
{ assert snapshot(
process.out.bam.collect { meta, bamFile -> [meta, file(bamFile).name, bam(bamFile).getReadsMD5()] },
process.out.findAll { key, val -> key.startsWith("versions") },
).match() }
)
Generated by Codex
LouisLeNezet
left a comment
There was a problem hiding this comment.
You just need now to update the meta and snapshot
| { assert snapshot( | ||
| process.out.bam, | ||
| process.out.bam.collect { meta, bamFile -> [meta, file(bamFile).name, file(bamFile).exists(), file(bamFile).size() > 0] }, | ||
| file(process.out.log[0][1]).readLines().findAll { it.startsWith("decompHash") }, |
There was a problem hiding this comment.
I meant
assertAll (
{ assert process.success },
{ assert file(process.out.log[0][1]).readLines().findAll { it.startsWith("decompHash") } },
{ assert snapshot(
process.out.bam.collect { meta, bamFile -> [meta, file(bamFile).name, bam(bamFile).getReadsMD5()] },
process.out.findAll { key, val -> key.startsWith("versions") },
).match() }
)
Generated by Codex
|
Pushed an update for the align test snapshots.
I also tested the exact
So for this specific malformed-BAM regression test, I moved the Local checks:
Comment added by Codex |
Generated by Codex
Generated by Codex
Description
versions.ymloutput with aversions_narfmaptuple broadcast totopic: versionsdragen-os --version 2>&1to report the NARFMAP versionGenerated by Codex
PR checklist
Closes #12319
topic: versions.label.Tests
nf-core modules lint narfmap/hashtable(59 passed)