Update DEEPVARIANT/* modules to support phasing. #11859
Open
awgymer wants to merge 2 commits into
Open
Conversation
…pture pattern for small model calls - see google/deepvariant#1078
Contributor
|
The tests and linting are sad. |
Contributor
Author
|
Yeah, setting the phasing to false fixes the tests but I am waiting for some feedback on whether a hard failure like this is expected with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the split processes for DEEPVARIANT to support using phased read inputs passed between processes.
Also fix the capture pattern for small model call records output in MAKE_EXAMPLES for prefixes containing a
.See google/deepvariant#1078 for more details on the root cause of these issues and need to fix.
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda