feat(vcontact3): add vcontact3/prepareddatabases module#11738
feat(vcontact3): add vcontact3/prepareddatabases module#11738olawal1001 wants to merge 12 commits into
Conversation
jfy133
left a comment
jfy133
left a comment
There was a problem hiding this comment.
Good first start @olawal1001 !
Comments below :) Main thing is the meta.yaml documentation file has not yet been updated.
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
|
@olawal1001 please join the nf-core GitHub organisation (instructions: https://nf-co.re/join) so you don't have to wait for someone to approve execution of tests :) |
| def meta = process.out.database.get(0).get(0) | ||
| def dbDir = process.out.database.get(0).get(1) |
There was a problem hiding this comment.
You don't need these as variables, you can specify the process.out.database directly in the path() call on line 33.
You also can drop the testing of the meta, just the directory would be sufficient here.
| cat <<EOF > versions.yml | ||
| "${task.process}": | ||
| vcontact3: 3.1.6 | ||
| EOF |
There was a problem hiding this comment.
This still needs to be removed/replaced with the new system! Why did you resolve the previous commnet?
There was a problem hiding this comment.
I did replace it but I don't think it committed successfully.. I check again
| - clustering | ||
| - vcontact3 | ||
| tools: | ||
| ## TODO nf-core: Add a description and other details for the software below |
There was a problem hiding this comment.
All of these TODOs in this file need to be removed
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
|
The test failure seems to imply that the |
joined@jfy133 |
2 participants
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda