Open
Conversation
famosab
reviewed
Apr 2, 2026
Contributor
famosab
left a comment
famosab
left a comment
There was a problem hiding this comment.
Few things related to nf-test but looking good!
| tag "samtools/index" | ||
| tag "find/concatenate" | ||
|
|
||
| setup { |
Contributor
There was a problem hiding this comment.
That is a really large setup for a test. I think its fine but I would argue that one could generate the input file once and store it in test-datasets so that we do not compute it all the time :)
Comment on lines
+11
to
+14
| tuple val(meta), path(asm_to_ref_bam), path(asm_to_ref_bai), path(read_to_asm_bam), path(read_to_asm_bai) | ||
| tuple val(meta2), path(ref_fasta) | ||
| val(assembly_mode) // value : [ fully-phased | partially-phased ] | ||
| val(output_vcf) // value : [ true | false ] |
Contributor
There was a problem hiding this comment.
Can we put all these inputs into one tuple? That will make sure you're sure that EVERY time everything comes together in the right combination.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Add new nf-core module Portello.
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda