Add metamap for input/output in stringtie/merge#11108
Add metamap for input/output in stringtie/merge#11108Odulhin wants to merge 5 commits intonf-core:masterfrom
Conversation
famosab
left a comment
There was a problem hiding this comment.
Thank you for your contribution to nf-core! We really appreciate it. I added a few comments to your PR. Good work updating this module to adhere more to the nf-core guidelines
| tuple val(meta), path(bam) | ||
| path annotation_gtf |
There was a problem hiding this comment.
Can we put all these inputs into one tuple? That will make sure you're sure that EVERY time everything comes together in the right combination.
There was a problem hiding this comment.
I tried but I had issues to pass tests afterwards.
Instead I put the annotation_gtf inside a metamap which was easier and required less code modifications because in the related subworkflows it was already in this form only the metadata was discarded when calling the module.
There was a problem hiding this comment.
You can run
nextflow lint -format -sort-declarations -spaces 4 -harshil-alignmenton this file to clean this up nicely.
Summary
Closes #8686