Skip to content

Add metamap for input/output in stringtie/merge#11108

Open
Odulhin wants to merge 5 commits intonf-core:masterfrom
Odulhin:master
Open

Add metamap for input/output in stringtie/merge#11108
Odulhin wants to merge 5 commits intonf-core:masterfrom
Odulhin:master

Conversation

@Odulhin
Copy link
Copy Markdown
Contributor

@Odulhin Odulhin commented Apr 1, 2026

Summary

  • Add a metamap for input, output instead of the previous harcoded ones
  • Modify related subworkflow : bam_stringtie_merge
  • Update snapshots

Closes #8686

@Odulhin Odulhin self-assigned this Apr 1, 2026
@Odulhin Odulhin enabled auto-merge April 1, 2026 15:06
Copy link
Copy Markdown
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to nf-core! We really appreciate it. I added a few comments to your PR. Good work updating this module to adhere more to the nf-core guidelines

Comment on lines 12 to 13
tuple val(meta), path(bam)
path annotation_gtf
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put all these inputs into one tuple? That will make sure you're sure that EVERY time everything comes together in the right combination.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried but I had issues to pass tests afterwards.

Instead I put the annotation_gtf inside a metamap which was easier and required less code modifications because in the related subworkflows it was already in this form only the metadata was discarded when calling the module.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can run

nextflow lint -format -sort-declarations -spaces 4 -harshil-alignment

on this file to clean this up nicely.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update module: stringtie/merge

4 participants