Skip to content

fix(merqury): make optional spectra fl and st png outputs#11093

Open
MohineTAlam wants to merge 7 commits intonf-core:masterfrom
MohineTAlam:master
Open

fix(merqury): make optional spectra fl and st png outputs#11093
MohineTAlam wants to merge 7 commits intonf-core:masterfrom
MohineTAlam:master

Conversation

@MohineTAlam
Copy link
Copy Markdown
Contributor

@MohineTAlam MohineTAlam commented Mar 31, 2026

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Description:
Mark spectra-cn and spectra-asm fl/st PNG outputs as optional.

These plot variants are not consistently produced by Merqury across datasets,
while ln (log-scale) plots are reliably generated and retained as required
outputs to ensure QC completeness.

This prevents workflow failures due to missing non-essential plot files.

(linting and testing done)

Copy link
Copy Markdown
Contributor

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add (optional) in the meta.yml for each of the optional output ?
If possible a nf-test that don't produce these files would be nice.
Good to go otherwise.

MohineTAlam and others added 5 commits March 31, 2026 10:41
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
@MohineTAlam
Copy link
Copy Markdown
Contributor Author

Thanks! I've added optional: true to the corresponding outputs in meta.yml to keep it consistent with the module outputs.

These plot variants are not consistently produced by Merqury across datasets, so marking them optional reflects the actual behaviour.

@MohineTAlam
Copy link
Copy Markdown
Contributor Author

Hi let me know if there are any issues with this change :)

Copy link
Copy Markdown
Contributor

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants