fix(merqury): make optional spectra fl and st png outputs#11093
Open
MohineTAlam wants to merge 7 commits intonf-core:masterfrom
Open
fix(merqury): make optional spectra fl and st png outputs#11093MohineTAlam wants to merge 7 commits intonf-core:masterfrom
MohineTAlam wants to merge 7 commits intonf-core:masterfrom
Conversation
LouisLeNezet
requested changes
Mar 31, 2026
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Contributor
Author
|
Thanks! I've added These plot variants are not consistently produced by Merqury across datasets, so marking them optional reflects the actual behaviour. |
Contributor
Author
|
Hi let me know if there are any issues with this change :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile condaDescription:
Mark spectra-cn and spectra-asm fl/st PNG outputs as optional.
These plot variants are not consistently produced by Merqury across datasets,
while ln (log-scale) plots are reliably generated and retained as required
outputs to ensure QC completeness.
This prevents workflow failures due to missing non-essential plot files.
(linting and testing done)