Skip to content

fix(core): use %n in the integrity check plural to avoid a crash in L10N #65914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 1 commit into from
Oct 27, 2026
+2 −2
Merged

fix(core): use %n in the integrity check plural to avoid a crash in L10N #65914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/BackgroundJobs/CheckCodeIntegrityJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ public static function formatSummary(IL10N $l, array $summary): array {
if ($unverified !== []) {
$sentences[] = $l->n(
'The signature of %s is missing or invalid, so it could not be verified.',
'The signatures of %s are missing or invalid, so they could not be verified.',
'The %n signatures of %s are missing or invalid, so they could not be verified.',
count($unverified),
[implode(', ', $unverified)],
);
Expand Down
2 changes: 1 addition & 1 deletion tests/Core/BackgroundJobs/CheckCodeIntegrityJobTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ public static function dataFormatSummary(): array {
'unverified only' => [['files' => 0, 'unverified' => ['core']], ['The signature of core is missing or invalid, so it could not be verified.']],
'both' => [['files' => 1, 'unverified' => ['core', 'files']], [
'1 file does not match the signed release. It may have been modified or added without authorization.',
'The signatures of core, files are missing or invalid, so they could not be verified.',
'The 2 signatures of core, files are missing or invalid, so they could not be verified.',
]],
'missing parameters' => [[], []],
];
Expand Down
Loading