Skip to content

fix(core): use %n in the integrity check plural to avoid a crash in L10N - #65914

Open
abp002 wants to merge 1 commit into
nextcloud:masterfrom
abp002:fix/65670/integrity-summary-plural
Open

abp002 wants to merge 1 commit into
nextcloud:masterfrom
abp002:fix/65670/integrity-summary-plural

Conversation

@abp002

@abp002 abp002 commented Oct 26, 2026

Copy link
Copy Markdown

Summary

For admins using German, Russian, French, British English and nine other languages, the notification list fails with a ValueError (The arguments array must contain 2 items, 1 given in German) when the code integrity check finds a missing or invalid signature, and the email doesn't arrive either. The plural sentence has no %n, neither in English nor in the translations.

I added %n to the plural sentence, as in #48028. The sentence will show in English until it is translated again on Transifex.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Alejandro Borrego <210245044+abp002@users.noreply.github.com>
@abp002
abp002 requested a review from a team as a code owner October 26, 2026 06:42
@abp002
abp002 requested review from leftybournes, provokateurin, salmart-dev and sorbaugh and removed request for a team October 26, 2026 06:42
@abp002

abp002 commented Oct 26, 2026

Copy link
Copy Markdown
Author

/backport to stable35

@abp002

abp002 commented Oct 26, 2026

Copy link
Copy Markdown
Author

/backport to stable34

@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews feature: language/translations (l10n/i18n) Localization and translation matters community pull requests from community labels Oct 26, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews community pull requests from community feature: language/translations (l10n/i18n) Localization and translation matters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Plural translation without %n causes ValueError in L10NString when formatting code-integrity notifications (NC 35.0.2)

3 participants