-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(UserMountCache): Add back unique index for oc_mounts and use normal insert #56933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please review again. I only intend to backport the first commit, as the other ones are just improvements that are not strictly necessary to fix the bug. All tests should be passing now. |
PHPUnit failures still seems related |
|
Yes they are also, the files_external ones even though I don't understand why yet. |
1e89141 to
460c565
Compare
…al insert Signed-off-by: provokateurin <kate@provokateurin.de>
3378570 to
4449cd7
Compare
|
Hm sharding is stuck and an earlier run was canceled (by phpunit) due to timeout. I suspect this is related to the changes. |
4449cd7 to
341fd34
Compare
|
/backport to stable32 |
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/56933/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 341fd348
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56933/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Replaces #56929
With the unique index back there will be no more duplicate mounts, without modifying the transaction isolation level.
Also to avoid any future issues with this method, I went ahead and removed all usage (it was deprecated in 15.0.0 already).
Oracle will likely fail on the truncate for the same still unknown reason as in #54014.