Skip to content

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Dec 9, 2025

Replaces #56929

With the unique index back there will be no more duplicate mounts, without modifying the transaction isolation level.
Also to avoid any future issues with this method, I went ahead and removed all usage (it was deprecated in 15.0.0 already).

Oracle will likely fail on the truncate for the same still unknown reason as in #54014.

@provokateurin
Copy link
Member Author

Please review again. I only intend to backport the first commit, as the other ones are just improvements that are not strictly necessary to fix the bug. All tests should be passing now.

@SystemKeeper
Copy link
Contributor

  1. OCA\Files\Tests\Command\DeleteOrphanedFilesTest::testClearFiles
    TypeError: OCA\Files\Tests\Command\DeleteOrphanedFilesTest::getMountsCount(): Return value must be of type int, string returned

PHPUnit failures still seems related

@provokateurin
Copy link
Member Author

Yes they are also, the files_external ones even though I don't understand why yet.

…al insert

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
Copy link
Member Author

Hm sharding is stuck and an earlier run was canceled (by phpunit) due to timeout. I suspect this is related to the changes.

@provokateurin
Copy link
Member Author

/backport to stable32

@provokateurin
Copy link
Member Author

/backport to stable31

@provokateurin provokateurin merged commit 1829269 into master Dec 16, 2025
235 of 249 checks passed
@provokateurin provokateurin deleted the fix/duplicate-mounts branch December 16, 2025 09:44
@backportbot
Copy link

backportbot bot commented Dec 16, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/56933/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 341fd348

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56933/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants