-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: Add repair step for deduplicating mounts #54014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
06e274c to
974a08c
Compare
974a08c to
0e4cab9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
0e4cab9 to
00eb35f
Compare
|
/backport! to stable31 |
|
Need to trigger the backport for updated autoloader files |
nickvergessen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Robin it is fine to remove all entries, so instead we should use
server/lib/public/IDBConnection.php
Lines 298 to 311 in c414dde
| /** | |
| * Truncate a table data if it exists | |
| * | |
| * Cascade is not supported on many platforms but would optionally cascade the truncate by | |
| * following the foreign keys. | |
| * | |
| * @param string $table table name without the prefix | |
| * @param bool $cascade whether to truncate cascading | |
| * @throws Exception | |
| * @since 32.0.0 | |
| * | |
| * @psalm-taint-sink sql $table | |
| */ | |
| public function truncateTable(string $table, bool $cascade): void; |
Then we also don't need a progressbar or anything.
I removed the code deleting rows and just added a truncate table statement. I also removed the test, since IMO there's no point in testing this. |
|
@salmart-dev autoloaders need to be updated. |
|
@provokateurin I undid the change with the prefix which didn't make sense and the original error is back: on Oracle tests Do you have any idea why this may be happening? looking at the error, it seems like the right DB is not being selected (system instead of nextcloud). |
|
Truncate is rather new, maybe it was never used/tested against Oracle? But can't see from a quick glance where it would do something wrong. |
|
@salmart-dev maybe truncate is available now, since we dropped some really old Oracle versions. |
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
1716e3a to
4c0ea8a
Compare
|
Closing in favor of #56933 |
Summary
Since #32877 the index is no longer unique and there can be duplicate entries in oc_mounts. This repair step removes them, but doesn't fix the root cause.
Checklist