Repository navigation
fix(viewer): mount the elements again when comparing other files - #153
Merged
Merged
Conversation
Comparing other files while the viewer was open kept the elements of the first comparison and only handed them the new files. Handlers load once they are mounted, so nothing loaded the new files and the viewer showed its spinner forever. The elements of a comparison are keyed by both files compared now, and mounted again for every comparison, as they are for every file opened. Comparing the files already compared keeps the elements and does not wait for them to load again, like opening the file already open. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
skjnldsv
approved these changes
Oct 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 92.53% 92.54% +0.01%
==========================================
Files 51 51
Lines 4177 4187 +10
Branches 922 928 +6
==========================================
+ Hits 3865 3875 +10
Misses 289 289
Partials 23 23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing other files while the viewer was open kept the elements of the first comparison and only handed them the new files. Handlers load once they are mounted, so nothing loaded the new files and the viewer showed its spinner forever.
The elements of a comparison are keyed by both files compared now, and mounted again for every comparison, as they are for every file opened. Comparing the files already compared keeps the elements and does not wait for them to load again, like opening the file already open.
Required to allow switching between different file comparisons from Collectives sidebar version tab.
Assisted-by: ClaudeCode:claude-opus-5-5
🤖 AI (if applicable)