Repository navigation
Conversation
The elements of a comparison stay mounted, hidden, while an error shows, and their keys did not follow reloadKey: a retry mounted nothing, no element said it had loaded, and the spinner stayed. A new version of the compared file was not shown either. Side by side, a retry also waited for one element instead of two. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 92.54% 92.54%
=======================================
Files 51 51
Lines 4187 4187
Branches 928 930 +2
=======================================
Hits 3875 3875
Misses 289 289
Partials 23 23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Try again" in a comparison kept spinning forever: the compared elements stay mounted behind the error, and their key ignored
reloadKey, so nothing remounted. Side by side, the retry also only waited for one of the two.Same fix makes a new version of the compared file show up, like in the single view. Follow-up to #153.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.