quantum phase 3: add KeyVault lifecycle UX and read-path compatibility — introduces cast quantum subcommand group (bootstrap / add-key / remove-key / update-key-auth) that reuses the shared CastTxBuilder + ML-DSA signing pipeline, routes through `Quan#4
Open
eacet wants to merge 1 commit intoeng-2098-phase-2from
Open
quantum phase 3: add KeyVault lifecycle UX and read-path compatibility — introduces cast quantum subcommand group (bootstrap / add-key / remove-key / update-key-auth) that reuses the shared CastTxBuilder + ML-DSA signing pipeline, routes through `Quan#4eacet wants to merge 1 commit intoeng-2098-phase-2from
cast quantum subcommand group (bootstrap / add-key / remove-key / update-key-auth) that reuses the shared CastTxBuilder + ML-DSA signing pipeline, routes through `Quan#4eacet wants to merge 1 commit intoeng-2098-phase-2from
Conversation
…y — introduces `cast quantum` subcommand group (bootstrap / add-key / remove-key / update-key-auth) that reuses the shared `CastTxBuilder` + ML-DSA signing pipeline, routes through `QuantumWriteRequestV1`, and auto-applies `QUANTUM_LIFECYCLE_GAS_FLOOR`; distinguishes `--auth-key-id` (signer lane) from `--target-key-id` (key entry mutated). Adds shared `sol!`-backed KeyVault lifecycle calldata builders in `foundry-common` with byte-matched Phase 0 selector tests. Preserves `cast call` behavior for ordinary read paths while failing closed on all four lifecycle selectors with the frozen unsupported-simulation error. Moves CLI-policy lifecycle rejection out of the shared write-request validator (blocked `cast quantum` from signing its own legitimate payloads) into the `cast send` pre-build guard only.
This was referenced Apr 17, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4557121c61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist