quantum phase 2: finalize manual verification and auto-apply lifecycle gas floor — adds fork-side key_id == 0 invariant on bootstrap requests, moves KeyVault lifecycle-selector rejection into cast send pre-build (matching both Solidity and raw-hex sel#3
Open
eacet wants to merge 1 commit intofeature/eng-2098from
Open
quantum phase 2: finalize manual verification and auto-apply lifecycle gas floor — adds fork-side key_id == 0 invariant on bootstrap requests, moves KeyVault lifecycle-selector rejection into cast send pre-build (matching both Solidity and raw-hex sel#3eacet wants to merge 1 commit intofeature/eng-2098from
key_id == 0 invariant on bootstrap requests, moves KeyVault lifecycle-selector rejection into cast send pre-build (matching both Solidity and raw-hex sel#3eacet wants to merge 1 commit intofeature/eng-2098from
Conversation
…e gas floor — adds fork-side `key_id == 0` invariant on bootstrap requests, moves KeyVault lifecycle-selector rejection into `cast send` pre-build (matching both Solidity and raw-hex selector forms), and auto-applies `QUANTUM_LIFECYCLE_GAS_FLOOR` when `cast send` detects a bootstrap call so the path bypasses `eth_estimateGas` (which cannot simulate validator-published bootstrap transient state). Adds the `QUANTUM_LIFECYCLE_GAS_FLOOR` constant (parity with quantum-send-tx) and a regression test for the new bootstrap key_id guard.
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 17, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b763274efc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist