Skip to content

quest: plan what the pre-cut audit decided - #8892

Merged
moq-bot[bot] merged 1 commit into
mainfrom
quest-plan/pre-cut-audit
Nov 16, 2026
Merged

moq-bot[bot] merged 1 commit into
mainfrom
quest-plan/pre-cut-audit

Conversation

@kixelated

@kixelated kixelated commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The 0.22 cut publishes every Rust crate, JS package, and binding as a semver break, and freezes the lite-07 wire. After it, a removal or rename costs another breaking release and a wire change costs lite-08. The 2026-11-14 feature review judged about 50 work lines "ship as is". The maintainer asked for an exhaustive audit of the same window before the announcement: is each addition worth it, made for a long-term reason, named well, and as simple as it can be, and can lite-07 itself lose anything.

Approach

The audit covered d0b086e71b (the release merge base) to 6ac78b68ee, about 3,800 commits: a digest of moq.pro's and Kixel's roadmaps, fifteen read-only reviewers by area (about 480 work lines), my own check of the claims that became questions, and a 15-round interview in which the maintainer decided each finding. This PR writes those decisions into the quest tree. It changes no shipped code.

Every quest's Plan records its decision as ✅ chosen (rejected: ...), dated 2026-11-16, with the evidence. quest/m2/README.md has the index.

Area Quests (m2 unless noted)
lite-07 wire yield-defer L, ietf-records-per-track M, path-escape L, min-age-join M; edits to lite07 (now L), refresh-interval, group-drops, switch, and group-takeover (m3, now XL)
moq-net API group-api L, reconnect-off M, net-renames S, session-codes M
Sockets epic sockets: boy M, carla M, remove M
Unused API epic unused-api: net S, transport M, media M, js S
Relay and transports relay-memory M, congestion-names M, relay-config-names S, relay-connect-keys S, relay-014-leftovers S, transport-names S, stats-old-names S
Auth and crypto auth-grants M, auth-claims M, auth-attach-token S, e2ee-crate M, e2ee-format L (m3)
Catalog, drafts, formats epic hang04: sync M, entry-version M, video-warmup M, m2ts M, shape S; drafts-retire S, archive-v2 M, finish-sweep M, ts-typed-outcomes M, json-write-at M, consumers L; catalog-warmup M (m4)
Native media and gateways video-producer L, delay-hole-wait M, native-media-config M, audio-sink-names XS, vaapi-exports S, webrtc-bind M, gateway-align M, str0m-upstream L
JS and browser js-net-api M, signals-semantics M, ui-private M, browser-packages M
Bindings ffi-open-selectors M, dart-experimental S, libmoq-name M

Existing quests:

  • Moved into m2: m3/time-addressing-consumers (now m2/time-addressing/consumers) and m4/ietf-time-addressing. Moved to m5: m3/ts-multi-program-restart. Renamed: m3/release/demo-sockets-deploy to demos-deploy.
  • Deleted: m2/subscriber-min-age (reversed), m3/ietf-finish and m3/ietf-hole-stall (moq-transport interop polish between our own clients), m3/lite-finished-across-updates (its premise was the reopen that yield-defer deletes), and m3/release/libmoq-retire with libmoq-final-release (no stub: libmoq ships the real API).
  • Edited for a decision: about 65 others, among them the cut (cut now also requires relay-memory, the rind 0.4 adapters, and the FFI abort), lite07-finalize (four more Required), the m3/webrtc and vendor-sync quests (replanned for upstream str0m), the m5/e2ee and m5/net-wrap epics (crate renamed, format quest required), m3/ffi-exporter, the C release quests, and the intra-refresh epic.
  • The API review and feature review record what this run covered and learned, for their passes after m2.

Outside quest/:

  • AGENTS.md: two rules reworded, both agreed in the interview. A feature reaches the bindings when a binding user needs it (it read "keep all languages and wrappers at the same functionality", which mirrored unused features into every binding). A path segment's leading . is the one marker allowed inside a value.
  • Deleting ietf-hole-stall and ietf-finish left an ignored test and an interop skip naming them. The test (a_relay_with_holes_answers_a_wide_past_range_plus_live_over_moq_transport) and its test-inventory.allow line are removed, and the skip in test/interop/interop.sh and its README says the gap is not planned work.

Decisions

All 2026-11-16, maintainer. The headline ones, with what they reverse:

  • lite-07 loses YIELDED continuations (to lite-08, with takeover), GROUP Frame Start, the Padding stream and datagram types, and the count on SUBSCRIBE_DROP. It keeps datagram tracks with their lite-05/06 bridge, all seven lite versions, the hidden . prefix, the route plan, and Subscriber Min Age, which reverses 2026-11-14 (#8839 closed) and gains a reader. The ietf extension stays but costs nothing on a moq-lite track. The \ escape is finished, not removed.
  • Leaves the repository: socket endpoints (to Kixel; the demos return to their earlier format), about 98k lines of vendored WebRTC (back to upstream str0m 0.25, reversing 2026-10-30), three dead drafts, the moq-cluster draft with the route switch, and every public item with no caller.
  • Does not publish at 0.22: end-to-end encryption (its own moq-e2ee crate again, unpublished until moq-e2ee-01 is finished), video warmup in the catalog, the generated C API (libmoq 0.22 is the hand-written API's final line, reversing 2026-10-25), and Dart on the shared version.
  • Built before the cut, not after: declared ends from GROUP_END (reverses the 2026-11-14 move to m3), the frame-taking video producer, the moq-transport Timestamp deletion (reverses the move to m4), and an explanation of the relay's 17% memory growth, which the cut now waits on by name.
  • Bindings break twice: at 0.22, then at the exporter switch.
  • Not reopened: AUTH_ERROR's retry codes and AUTH_OK's rate fields.

One decision was made on a wrong fact, mine. I asked what to do with #8857 as an open PR ("delete the path, park #8857" was picked). It had merged ten hours earlier. video-warmup records the pick as it applies now, deleting the one-decoder path #8857 landed, and tells its PR to put this at the top of its body for the maintainer to confirm or reverse. catalog-warmup restores it from history with the producer.

Choices in the quests that the maintainer did not make are written as recommendations, not decisions. The larger ones: old config spellings are refused rather than aliased; reserve_unlisted_track becomes public for Kixel's socket port; reconnect needs three states (unset, off, a value) where "absent" already means default; the hole wait's live estimate lives on the playhead, not Delay::min; Read::End reports every group's declared end; the errored group end is fail(err).

Impact

Public API: none. Wire: none. This PR plans; each quest states its own break.

The cut now waits on 53 more m2 quests (51 new, 2 moved in): 6 L, 32 M, 14 S, and 1 XS. That is the cost of the decisions above.

Follow-ups

For other repositories' quest trees, to plan there:

  • Kixel: port moq_net::socket and its wrappers from the socket removal PR's parent commit (the port inherits the closed-endpoint race in quest/m0/test-flakes-3/py-socket-abort.md); move PublicKey into kixel-trust (its moq_crypto::sign::PublicKey import breaks at the cut either way); check each unused-API sweep for a caller before it lands.
  • moq.pro: port the staging build from media.clock to sync.clock; discard or rewrite any staging archive written by a main build (the format ships as version 2); the auth server handles strict grants, the link enum, and the attached-token change; check each unused-API sweep for a caller.
  • moq.dev: demos-deploy is rewritten for demos without sockets.

Seen but not changed: groups-never-overlap (planned 2026-11-15 in m3) tightens the hang draft's group rule after hang-04 would publish, so it may belong in m2.

Validation

  • quest check and quest check --base origin/main: 542 documents ok.
  • just check on the branch: passed (rs check and test with 12,825 tests, js, markdown, gh, tooling, shell, quest), which covers the removed test and the interop script.
  • No behavior to exercise: quest files, two rule sentences, and one deleted ignored test.

Models

Size: L
Implementer: Claude Code, claude-fable-5-2, unknown effort

🤖 Generated with Claude Code

(Written by Claude Fable 5.2)

Review

Rewritten by quest review after each round.

  • Head: 39e9acd

  • Base: origin/main at 0019174

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, xhigh effort

  • Session: 01a1e3b8-194d-7501-b7d6-05e4366da9aa, round 1

  • Score: 10/10, The change records planning decisions without changing runtime behavior, and no blocking defects were found.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

An audit of everything on main since release, and of the lite-07 draft,
ahead of the 0.22 cut. The maintainer decided each finding; this records
them as m2 quests, moves and deletes the quests they supersede, and
rewords two AGENTS.md rules.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 16, 2026 09:41
@kixelated
kixelated enabled auto-merge November 16, 2026 09:41

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: the PR's non-quest edits in full, plus a reference check across the quest tree. I did not read each quest document's content.

  • AGENTS.md rules: two reworded rules, one for the leading . path segment and one for when a feature reaches the bindings.
  • Removed ignored test: a_relay_with_holes_answers_a_wide_past_range_plus_live_over_moq_transport and its sh/gh/test-inventory.allow line are both gone, so the inventory stays consistent.
  • Interop skip text: the test/interop/interop.sh skip detail and test/interop/README.md no longer point at the deleted ietf-finish quest.
  • Quest tree: about 130 quest documents added, edited, moved or deleted. No dangling links to the deleted quests remain, only prose that records the deletions.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 9b99c93 Nov 16, 2026
6 of 7 checks passed
@moq-bot
moq-bot Bot deleted the quest-plan/pre-cut-audit branch November 16, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant