Skip to content

quest: plan the pre-cut correctness audit's fixes - #9010

Merged
kixelated merged 6 commits into
mainfrom
quest-plan/precut-correctness
Nov 17, 2026
Merged

kixelated merged 6 commits into
mainfrom
quest-plan/precut-correctness

Conversation

@kixelated

@kixelated kixelated commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The maintainer asked for an exhaustive audit of everything between release and main before the 0.22.0 cut: bugs, performance, unexpected behavior, fragile or over-complex code, and unproven correctness. The 2026-11-16 audit (moq-dev/moq#8892) judged the same window for purpose, caller, and API. The last audit aimed at bugs was 2026-10-24 (moq-dev/moq#6707).

Approach

The scope was set with the maintainer: correctness only, run now, over the whole window. API shape and purpose are owned by the 2026-11-16 audit and the API shape review. Code an open m2 quest replaces is also out: the old lite-07 route rule, YIELDED continuations, lite-07 sequence addressing, socket endpoints, and moq-e2ee.

The audit covered release ca3b801a6c to main ec5a19540f (4,030 commits) with 18 read-only reviewers in 11 areas, plus gap-fill passes for what the first passes left unread. The areas were the net model, sessions and lite, moq-transport (two passes), transport (two passes), relay/auth/stats, js/net (two passes), formats (two passes), native media (two passes), gateways, browser, and bindings. I then verified the top findings myself:

  • Reproduced: the @moq/video Node load failure (ERR_MODULE_NOT_FOUND) and the signals lost wakeup (bun test).
  • Confirmed from source: the stats double count, the WHEP hang, the NixOS stop propagation, the CLI capture failure, the fMP4 init queue, the moq-c runtime block, and the relay high-key growth.
  • Not re-checked: every other finding rests on its reviewer's source reading, so each quest says to reproduce it first.

Structure:

Decisions

The agent took recommendations under /quest-afk; the maintainer answered each on 2026-11-17 (comment), and each quest's Plan records the answer:

  1. ✅ Every finding gates the 0.22.0 cut (rejected: gating only what release lacks, the afk recommendation; gating none). Expressed by moving the nine standalone quests into the precut-fixes epic, so the cut keeps one Required link (rejected: the cut requiring each quest by hand, a list nobody keeps current).
  2. ✅ Every new quest in m1 (rejected: only precut-fixes in m1).
  3. ✅ The CLI reopens a failed mic with release's backoff; moq-audio stays reopen-free per moq-dev/moq#7706 (rejected: the reopen back in moq-audio; ending only the audio track with no reopen).
  4. ✅ ts-step-damage leaves the epic as a standalone, low-priority m1 quest that does not gate the cut, keeping its drop-and-count design and "reproduce first" (rejected: keeping it in the gate; deleting it). It links ts-passthrough-splice in moq-dev/moq#9035, which handles the whole-source step on the passthrough lane.
  5. ✅ export archive drops one failed broadcast and keeps the rest, updating doc/bin/cli.md (rejected: keeping the documented behavior).
  6. ✅ The NixOS moq-auth unit sets stopIfChanged = false (rejected: wants).
  7. ✅ Backport the relay high-key fix to release after it lands on main (rejected: ship it only with the cut).

From review: stats-minted-reconnect now promises continuity only within the aggregator's grace, as Merged's docs already say, and its test covers a return just past the grace (rejected: a bounded ledger of retired nodes, memory for every departed node to fix a case the docs already exclude).

Dropped findings:

  • The shared server allocator (moq-dev/moq#8926) dividing estimates across concurrent sessions: the PR's use case is fan-out of one encoder, where each session probing for the shared total is intended.
  • moqsink's loopback session drop behind a since-fixed flake: no evidence of a product bug.
  • Low-cost items:
    • a datagram-only moq-transport SUBSCRIBE ignoring its own cancel (costs only that request);
    • room metadata flicker on a catalog change;
    • the opt-in preview="encoded" encoder queue;
    • MSF number parity between JS and Rust (JS would start refusing catalogs it plays);
    • capture xrun logging on the audio thread;
    • the audio bus doc's callback claim (nothing drives it from a callback).

Impact

None: quest files only.

Alternatives

  • Fold the correctness lens into the feature review's delta pass after m2 lands. Rejected by the maintainer: findings would queue behind the multicast critical path.
  • Re-run every lens over the whole window. Rejected as a repeat of the 2026-11-16 audit.

Follow-ups

Coverage gaps the reviewers named, for the feature review's delta pass after m2:

  • ietf joining-FETCH and TrackStatus bodies;
  • js/net window.ts and fill.ts;
  • TS schedule.rs, programs.rs, and rate.rs;
  • moq-c api.rs;
  • most of the Kotlin, Swift, Dart, and Python wrappers;
  • the OBS plugin's output and dock;
  • PipeWire, ScreenCaptureKit, and WGC capture;
  • js/watch sync.ts and broadcast.ts.

Models

Size: M
Implementer: Claude Code, claude-opus-5-5, unknown effort
Implementer: Claude Code, claude-opus-5-5, unknown effort (iterate, S)

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

mechanical fix by codex, gpt-6.1-sol, medium effort: Merged base and mechanically replaced three links to completed, deleted quests with their landing commits; ran nix develop --no-update-lock-file --command just ci base and git diff --check. (head 7a890a0)

Rewritten by quest review after each round.

  • Head: e47fb27

  • Base: origin/main at 52c75cd

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, high effort

  • Session: 01a1eb2c-1560-75b0-8bd2-6999cce46df6, round 1

  • Score: 9/10, Ready to land as planning work, with no actionable defects found and reproduction and validation explicitly deferred to implementation.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 3 commits November 17, 2026 05:04
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rectness

# Conflicts:
#	quest/m2/time-addressing/lite07.md
@kixelated
kixelated marked this pull request as ready for review November 17, 2026 13:11
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e4e97c1e-c6ae-4c07-b9b5-eb2d61128b71
Commits

Reviewing files that changed from the base of the PR and between b4c1db7 and 7a890a0.

Files selected for processing: 23

  • quest/m1/precut-fixes/README.md
  • quest/m1/precut-fixes/archive-isolate.md
  • quest/m1/precut-fixes/audio-capture-drift.md
  • quest/m1/precut-fixes/bindings-negative-duration.md
  • quest/m1/precut-fixes/capture-audio-reopen.md
  • quest/m1/precut-fixes/error-outcomes.md
  • quest/m1/precut-fixes/failover-models-sync.md
  • quest/m1/precut-fixes/fmp4-init-backpressure.md
  • quest/m1/precut-fixes/js-net-leaks.md
  • quest/m1/precut-fixes/lite07-range-union.md
  • quest/m1/precut-fixes/moq-c-rate-thread.md
  • quest/m1/precut-fixes/nix-auth-restart.md
  • quest/m1/precut-fixes/relay-config-loud.md
  • quest/m1/precut-fixes/relay-high-key.md
  • quest/m1/precut-fixes/signals-flip-back.md
  • quest/m1/precut-fixes/stats-minted-reconnect.md
  • quest/m1/precut-fixes/tail-ledger-bound.md
  • quest/m1/precut-fixes/video-decode-lifecycle.md
  • quest/m1/precut-fixes/video-node-imports.md
  • quest/m1/precut-fixes/whep-egress-end.md
  • quest/m1/ts-step-damage.md
  • quest/m3/audit-perf.md
  • quest/m3/release/cut.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

pullfrog[bot]
pullfrog Bot previously approved these changes Nov 17, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Quest-file-only PR; I skimmed the epic README, the perf audit edit and the cut link, and did not read the individual quests line by line.

  • m1/precut-fixes epic — 11 quests for regressions and first-publish defects, linked from m3/release/cut.md as a cut requirement.
  • Standalone m1 quests — 9 quests for findings release already has.
  • m3/audit-perf.md — adds eight measured-first perf items.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)
Reviewed commit: 9c8ae3b5d6a49d5746a0ccee3a92b73bdb8329cd

Medium, quest/m1/precut-fixes/stats-minted-reconnect.md:3–29: scope the fix to reconnects within grace, or account for reconnects after it. The plan promises a reconnect never counts the node twice, but copying the previous entry works only while that entry exists. In aggregate.rs:859–869, after grace the old contribution is folded into the shared retired total and its path lookup is removed. A node returning with intact counters after that still counts from zero on top of its retired contribution. The existing config docs already acknowledge this limit. If the cut fix is deliberately just for ordinary redials within grace, say so and test the boundary; otherwise design bounded accounting for retired nodes before promising never.

Gating changes introduced since release while separately backporting the relay resource fix makes sense. I reviewed the plan and traced this stats path; I did not rerun the audit or its reproductions.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Maintainer decision (2026-11-17, asked in the /quest-run m0/m1/m2 coordinating session, one question per decision). Pick: /quest-merge once these are applied.

  1. ✅ Every finding gates the 0.22.0 cut, so the nine standalone m1 quests (relay-high-key, whep-egress-end, signals-flip-back, error-outcomes, video-decode-lifecycle, js-net-leaks, bindings-negative-duration, failover-models-sync, audio-capture-drift) gate it too (rejected: gating only what release lacks; gating none). This overrides the afk recommendation.
  2. ✅ All new quests in m1 (rejected: only precut-fixes in m1).
  3. ✅ The CLI reopens a failed mic with release's backoff; moq-audio stays reopen-free per feat(audio)!: share one capture across independent consumers #7706 (rejected: reopen back in moq-audio; end only the audio track with no reopen).
  4. ✅ ts-step-damage leaves the precut-fixes epic and becomes a standalone, low-priority m1 quest that does not gate the cut (rejected: keeping it in the gate; deleting it). It was read from source with no field report: a lone PID's PTS step needs a corrupt PES header or a muxer resetting one stream. Its drop-and-count design with a confirming packet stands for whenever it is done, reproduce first. Cross-link it with ts-passthrough-splice (moq-dev/moq#9035), which handles the whole-source step on the passthrough lane.
  5. ✅ export archive logs and drops a failed broadcast and keeps recording the rest; update doc/bin/cli.md (rejected: keep the documented behavior).
  6. ✅ The NixOS moq-auth unit sets stopIfChanged = false (rejected: wants).
  7. ✅ Backport the relay high-key track fix to release as its own PR after it lands on main (rejected: ship it only with the cut).

(Written by Claude Opus 5.5 with high)

Every finding gates the cut, so the nine standalone m1 quests move into
the precut-fixes epic; ts-step-damage leaves it as a standalone
low-priority quest. The stats quest keeps the documented grace limit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Applied the maintainer's decisions in e47fb27: the nine standalone quests moved into quest/m1/precut-fixes/, so every finding gates the cut through its one Required link; ts-step-damage is now quest/m1/ts-step-damage.md, standalone and low priority, linked to #9035; each quest's Plan records its answer.

The review's stats-grace finding (pullrequestreview-5939092567): fixed by scoping stats-minted-reconnect to a return within Config::grace, as Merged's docs (rs/moq-stats/src/aggregate.rs:88) already promise, with a boundary test just past the grace.

(Written by Claude Opus 5.5)

pullfrog[bot]
pullfrog Bot previously approved these changes Nov 17, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes since the prior pullfrog review: the maintainer's decisions applied to the quest files.

  • Epic consolidation — the nine standalone quests moved into quest/m1/precut-fixes/, so the cut keeps one Required link.
  • Decisions recorded — "Recommended" entries became "Decided 2026-11-17" with the maintainer's answers (stopIfChanged = false, archive isolation, CLI-side mic reopen, relay backport).
  • ts-step-damage — now a standalone, low-priority m1 quest outside the gate, linking #9035.
  • stats-minted-reconnect — continuity is scoped to the aggregator's grace, with a boundary test added.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)
Reviewed commit: e47fb27b56b99ef4450659a302159eb7b9ae5bc9

The stats plan now scopes the no-double-count guarantee to the grace period and tests both sides of that boundary. That addresses my earlier finding.

One dependency to make explicit now that every child gates the cut: quest/m1/precut-fixes/moq-c-rate-thread.md:19–21 recommends adding a dedicated follower thread, but #8964 removes that follower entirely and applies rate changes in the producer's frame-write path. If #8964 lands first, run the planned cross-session timing regression on that path and close this quest if it passes; don't add a second follower just to clear the gate.

Static review; I did not reproduce or rerun the audit cases.

@kixelated
kixelated added this pull request to the merge queue Nov 17, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 17, 2026
@moq-bot

moq-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

quest land watch: the merge queue removed this pull request at e47fb27 because its merge_group build failed (failed_checks).

The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.

Queue / Queue (job) failure at step Check:

…zp09bssia-git-2.56.0/bin/git config --local --get-all includeif.gitdir:/github/workspace/.git.path
/github/runner_temp/git-credentials-d072b6df-4147-4850-bd93-feb69adad483.config
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --unset includeif.gitdir:/github/workspace/.git.path \/github\/runner_temp\/git\-credentials\-d072b6df\-4147\-4850\-bd93\-feb69adad483\.config
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --get-all includeif.gitdir:/github/workspace/.git/worktrees/*.path
/github/runner_temp/git-credentials-d072b6df-4147-4850-bd93-feb69adad483.config
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --unset includeif.gitdir:/github/workspace/.git/worktrees/*.path \/github\/runner_temp\/git\-credentials\-d072b6df\-4147\-4850\-bd93\-feb69adad483\.config
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Removing credentials config '/var/cache/github-runner-work/_temp/git-credentials-d072b6df-4147-4850-bd93-feb69adad483.config'
##[endgroup]
Prepare all required actions
Getting action download info
Download action repository 'taiki-e/install-action@cfdb7ed4ccc7c7dce37759eae89dc5674b469b39' (SHA:cfdb7ed4ccc7c7dce37759eae89dc5674b469b39)
##[group]Run ./.github/actions/just
env:
  BASE: b4c1db719358a25e351771e8ad33f01d45169bb0
  CHECK_FAIL_FAST: 1
  NEXTEST_TEST_THREADS: 24
##[endgroup]
##[start-action display=Use the NixOS runner toolchain;id=__self.__run]
##[group]Run just --version
�[36;1mjust --version�[0m
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  BASE: b4c1db719358a25e351771e8ad33f01d45169bb0
  CHECK_FAIL_FAST: 1
  NEXTEST_TEST_THREADS: 24
##[endgroup]
just 1.59.0
##[end-action id=__self.__run;outcome=success;conclusion=success;duration_ms=10]
##[start-action display=Run taiki-e/install-action@cfdb7ed4ccc7c7dce37759eae89dc5674b469b39;id=__self.__taiki-e_install-action]
##[end-action id=__self.__taiki-e_install-action;outcome=skipped;conclusion=skipped;duration_ms=0]
Prepare all required actions
Getting action download info
Download action repository 'jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de' (SHA:88acf2bb50552c7c508cbac13e5f8c576b95b1de)
##[group]Run ./.github/actions/rust-cache
with:
  write: true
env:
  BASE: b4c1db719358a25e351771e8ad33f01d45169bb0
  CHECK_FAIL_FAST: 1
  NEXTEST_TEST_THREADS: 24
##[endgroup]
##[start-action display=Require main's merge queue on self-hosted runners;id=__self_2.__run]
##[end-action id=__self_2.__run;outcome=skipped;conclusion=skipped;duration_ms=0]
##[start-action display=Cache credentials;id=__self_2.__run_2]
##[end-action id=__self_2.__run_2;outcome=skipped;conclusion=skipped;duration_ms=0]
##[start-action display=Run jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de;id=__self_2.mbx]
##[group]Run jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de
with:
  version: 1.30.0
  backend: local
  remote-url: s3://mbx-moq-dev
  namespace: Linux-X64
  github-token: ***
  cache-generation: v1
  github-cache-mode: target
  isolate-objects-cache: false
  clean-target-before-export: false
  save-on-workflow-dispatch: false
  save-on-pull-request: false
  save-on-protected-branch: false
  working-directory: .
  cache-links: auto
env:
  BASE: b4c1db719358a25e351771e8ad33f01d45169bb0
  CHECK_FAIL_FAST: 1
  NEXTEST_TEST_THREADS: 24
##[endgroup]
Set up mbx 1.30.0
##[end-action id=__self_2.mbx;outcome=success;conclusion=success;duration_ms=569]
##[start-action display=Drop another mbx version's private state;id=__self_2.__run_3]
##[group]Run : "${VERSION:?the mbx action reported no version}"
�[36;1m: "${VERSION:?the mbx action reported no version}"�[0m
�[36;1mstamp="$HOME/.cache/moq-mbx-versions$RUNNER_WORKSPACE"�[0m
�[36;1mif [ "$(cat "$stamp" 2>/dev/null)" != "$VERSION" ]; then�[0m
�[36;1m  mbx clean --under "$RUNNER_WORKSPACE"�[0m
�[36;1m  mkdir -p "${stamp%/*}"�[0m
�[36;1m  printf '%s\n' "$VERSION" > "$stamp"�[0m
�[36;1mfi�[0m
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  BASE: b4c1db719358a25e351771e8ad33f01d45169bb0
  CHECK_FAIL_FAST: 1
  NEXTEST_TEST_THREADS: 24
  MBX_CACHE_LINKS: 1
  MBX_REMOTE_URL: 
  VERSION: 1.30.0
##[endgroup]
##[end-action id=__self_2.__run_3;outcome=success;conclusion=success;duration_ms=8]
##[start-action display=Sweep the cache before building;id=__self_2.__run_4]
##[group]Run auto=$(env -i HOME="$HOME" PATH="$PATH" mbx settings get gc.auto)
�[36;1mauto=$(env -i HOME="$HOME" PATH="$PATH" mbx settings get gc.auto)�[0m
�[36;1mif [ "$auto" != "false" ]; then�[0m
�[36;1m  echo "::error::the runner's global mbx config must set gc.auto = false, but it reads '$auto' without MBX_* variables"�[0m
�[36;1m  exit 1�[0m
�[36;1mfi�[0m
�[36;1mmbx gc�[0m
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  BASE: b4c1db719358a25e351771e8ad33f01d45169bb0
  CHECK_FAIL_FAST: 1
  NEXTEST_TEST_THREADS: 24
  MBX_CACHE_LINKS: 1
  MBX_REMOTE_URL: 
##[endgroup]
evicted 0 objects and 0 action results (0 B logical); 49.9 GiB logical remain
##[end-action id=__self_2.__run_4;outcome=success;conclusion=success;duration_ms=907]
##[start-action display=Check the cache;id=__self_2.__run_5]
##[end-action id=__self_2.__run_5;outcome=skipped;conclusion=skipped;duration_ms=0]
##[start-action display=Cargo shim;id=__self_2.__run_6]
##[group]Run mbx setup --yes
�[36;1mmbx setup --yes�[0m
�[36;1mshim=$(mbx setup --status 2>/dev/null | sed -n '1s/.*: //p' || true)�[0m
�[36;1mif [ ! -e "$shim" ]; then�[0m
�[36;1m  echo "::error::mbx setup installed no Cargo shim: $(mbx setup --status 2>&1)"�[0m
�[36;1m  exit 1�[0m
�[36;1mfi�[0m
�[36;1mecho "${shim%[/\\]*}" >> "$GITHUB_PATH"�[0m
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  BASE: b4c1db719358a25e351771e8ad33f01d45169bb0
  CHECK_FAIL_FAST: 1
  NEXTEST_TEST_THREADS: 24
  MBX_CACHE_LINKS: 1
  MBX_REMOTE_URL: 
##[endgroup]
refreshed the Cargo shim at /var/cache/github-runner-home/.local/share/mbx/bin/cargo
##[end-action id=__self_2.__run_6;outcome=success;conclusion=success;duration_ms=59]
##[group]Run rm -rf target/cargo-timings
�[36;1mrm -rf target/cargo-timings�[0m
�[36;1mnix develop --command just ci "$BASE"�[0m
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash -e {0}
env:
  BASE: b4c1db719358a25e351771e8ad33f01d45169bb0
  CHECK_FAIL_FAST: 1
  NEXTEST_TEST_THREADS: 24
  MBX_CACHE_LINKS: 1
  MBX_REMOTE_URL: 
##[endgroup]
warning: ignoring untrusted flake configuration setting 'extra-substituters'.
Pass '--accept-flake-config' to trust it
warning: ignoring untrusted flake configuration setting 'extra-trusted-public-keys'.
Pass '--accept-flake-config' to trust it
warning: ignoring untrusted flake configuration setting 'fallback'.
Pass '--accept-flake-config' to trust it
CI_STRICT=1 NEXTEST_PROFILE=ci sh/dispatch.sh ci "$BASE"
changed: base b4c1db719358a25e351771e8ad33f01d45169bb0
ci: check biome started
ci: check quest started
ci: check shell started
ci: check quest failed in 3s
ci: check shell cancelled in 3s
##[group]check quest
Dev-shell quest: /nix/store/gcwghr22h2g69zjagfaraj77mk8xxm7x-quest-0c9a35d/bin/quest
quest: quest/m1/precut-fixes/error-outcomes.md:37: link does not resolve: /quest/m2/session-codes.md
quest: quest/m1/precut-fixes/signals-flip-back.md:22: link does not resolve: /quest/m2/signals-semantics.md
quest: quest/m1/precut-fixes/signals-flip-back.md:29: link does not resolve: /quest/m2/signals-semantics.md
##[endgroup]
##[group]check shell
##[endgroup]
ci: check biome cancelled in 3s
##[group]check biome
uv run --no-project python sh/js/install.py frozen
bun install v1.4.4 (38afee6c8)
Resolving dependencies
Resolved, downloaded and extracted [1]

$ bun run --cwd js/libav build
$ bun build.ts
warning: ignoring untrusted flake configuration setting 'extra-substituters'.
Pass '--accept-flake-config' to trust it
warning: ignoring untrusted flake configuration setting 'extra-trusted-public-keys'.
Pass '--accept-flake-config' to trust it
warning: ignoring untrusted flake configuration setting 'fallback'.
Pass '--accept-flake-config' to trust it

shutting down�[Kerror: interrupted by the user
error: recipe `biome` failed on line 143 with exit code 143
##[endgroup]
##[error]ci: check quest failed
ci: wall and CPU seconds per module
     3       0  check biome (cancelled)
     3       3  check quest (failed)
     3       1  check shell (cancelled)
     3       5  whole run
error: recipe `ci` failed on line 120 with exit code 1
##[error]Process completed with exit code 1.
##[group]Run actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9
with:
  name: cargo-timings
  path: target/cargo-timings/cargo-timing-*.html
  if-no-files-found: ignore
  retention-days: 14
  compression-level: 6
  overwrite: false
  include-hidden-files: false
  archive: true
env:
  BASE: b4c1db719358a25e351771e8ad33f01d45169bb0
  CHECK_FAIL_FAST: 1
  NEXTEST_TEST_THREADS: 24
  MBX_CACHE_LINKS: 1
  MBX_REMOTE_URL: 
##[endgroup]
No files were found with the provided path: target/cargo-timings/cargo-timing-*.html. No artifacts will be uploaded.
Post job cleanup.
##[start-action display=Run jdx/mr-boxington-action@88acf2bb50552c7c508cbac13e5f8c576b95b1de;id=__6b381872-0e40-4c03-8533-d869ed2b279c.mbx]
##[end-action id=__6b381872-0e40-4c03-8533-d869ed2b279c.mbx;outcome=skipped;conclusion=skipped;duration_ms=0]
Post job cleanup.
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git version
git version 2.56.0
Temporarily overriding HOME='/var/cache/github-runner-work/_temp/e06879ce-4796-4d2a-9b23-5317fc78dbd2' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --global --add safe.directory /var/cache/github-runner-work/moq/moq
Removing SSH command configuration
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp core\.sshCommand
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]/nix/store/i2m3w4ly2w6grrmk1j59rb7zp09bssia-git-2.56.0/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
A job completed hook has been configured by the self-hosted runner administrator
##[group]Run '/nix/store/qrn6ds64bzvwbm5nwf245ifz2c6jb9xw-ci-cache-gc.sh/bin/ci-cache-gc.sh'
shell: /nix/store/lfm00fnq66xfgbn099vqckabyl5jllz6-bash-interactive-5.3p20/bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
evicted 0 objects and 0 action results (0 B logical); 49.9 GiB logical remain
evicted 0 objects and 0 action results (0 B logical); 49.9 GiB logical remain
Cleaning up orphan processes

(written by quest land watch)

@moq-bot

moq-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

quest land watch: armed auto-merge on this pull request at 7a890a0, so it joins the back of the merge queue once its required checks pass, with the land fixer's fix (codex, gpt-6.1-sol, medium effort): Merged base and mechanically replaced three links to completed, deleted quests with their landing commits; ran nix develop --no-update-lock-file --command just ci base and git diff --check..

(written by quest land watch)

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes since the prior pullfrog review: a link-only fix.

  • Repointed completed quest links — three references to deleted quests (session-codes, signals-semantics) now point at their landing commits.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit 00ae663 Nov 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant