Skip to content

Fix(frontend): Fail back correctly when no higher quality PFP exists #7946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ceebug wants to merge 1 commit into from
Closed

Fix(frontend): Fail back correctly when no higher quality PFP exists #7946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/ui/src/components/base/FullImage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,20 @@ function swapImageSrc(
const originalSrc = imgEl.src
if (originalSrc === fullUrl) return

imgEl.src = fullUrl

let reverted = false
const revert = () => {
if (reverted) return
reverted = true
imgEl.removeEventListener('error', onError)
imgEl.src = originalSrc
for (const { target, type, capture } of revertTargets) {
target.removeEventListener(type, revert, capture)
}
}
const onError = () => revert()

imgEl.addEventListener('error', onError, { once: true })
imgEl.src = fullUrl

for (const { target, type, capture } of revertTargets) {
target.addEventListener(type, revert, capture)
Expand Down Expand Up @@ -67,4 +70,5 @@ function onDragStart(event: DragEvent) {
event.dataTransfer.setData('text/uri-list', props.rawSrc)
event.dataTransfer.setData('text/plain', props.rawSrc)
}

</script>
Loading