Skip to content

Fix(frontend): Fail back correctly when no higher quality PFP exists - #7946

Closed
Ceebug wants to merge 1 commit into
modrinth:mainfrom
Ceebug:PFP-FailbackFix
Closed

Ceebug wants to merge 1 commit into
modrinth:mainfrom
Ceebug:PFP-FailbackFix

Conversation

@Ceebug

@Ceebug Ceebug commented Oct 13, 2026

Copy link
Copy Markdown

Fixes #7907

Signed-off-by: Ceebug <caseydegan@outlook.com>
@github-actions

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@Ceebug

Ceebug commented Oct 13, 2026

Copy link
Copy Markdown
Author

Now we add an error listener to check if the url loads and if it doesn't we stop tryna use the higher resolution and fall back to low res

@Ceebug

Ceebug commented Oct 13, 2026

Copy link
Copy Markdown
Author

Much better then a fallback image

@mergify

mergify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

This pull request is closed, so it cannot be queued. Reopen it to get the box back.

@IMB11 IMB11 closed this Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

The script that loads the higher res version of a PFP fails back incorrectly if one doesn't exist

2 participants