Repository navigation
docs(docker): drop the stale --db-path comments in the fetch and git Dockerfiles - #5531
Conversation
…Dockerfiles The fetch and git Dockerfiles carried a comment copied from a database server's image, telling the user to pass --db-path and mount a db file. Neither server has such an option. Fetch needs no mount, so its comment goes; git's now says to bind-mount the repository and pass its path to --repository. The git README's container-user line was already corrected by #5473. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>
|
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 1 | 1 | 0 | 0 |
| Head | 1 | 1 | 0 | 0 |
Updated by this run for fafb59a78826b6daafc3a6f4d68545628e576b0f.
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 14 | 2 | 0 | 0 |
| Head | 14 | 2 | 0 | 0 |
Updated by this run for fafb59a78826b6daafc3a6f4d68545628e576b0f.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the documentation-only Dockerfile guidance updates.
No open issues 🎉
What changed in this PR
Corrects stale Dockerfile guidance for the Python Fetch and Git servers, addressing the remaining documentation fixes in #5483. Only comments change; image behavior is unchanged.
Changes:
- Removes Fetch’s incorrect database-path and mount instructions.
- Updates Git’s comment to describe repository bind mounts and
--repositorywith an in-container path. - Leaves the Git README unchanged because #5473 already corrected its runtime-user documentation.
| File | Description |
|---|---|
src/git/Dockerfile |
Replaces database guidance with repository-mount and confinement instructions. |
src/fetch/Dockerfile |
Removes the stale --db-path comment. |
Review effort: Balanced
|
Copilot round 1: clean, no findings and no suppressed comments. The review loop stops here (clean-round exit). |
Closes #5483
Description
Both Python servers' Dockerfiles carried a comment copied from a database server's image, just above
ENTRYPOINT:Neither
mcp-server-fetchnormcp-server-githas a--db-pathoption.src/fetch/Dockerfile: the comment is removed. Fetch is an HTTP client and needs no mount.src/git/Dockerfile: the comment now says to bind-mount the host directory that holds the repositories, and to add--repositorywith an in-container path to confine the server to one of them, matching the README's Docker examples and its--repositoryguidance.The third point in the issue,
src/git/README.mdsaying the image runs as root, was already fixed onv2/mainby #5473. The README now documents the unprivilegedappuser and/home/app/.gitconfig, so this PR does not change it.Thanks to @muhammedriswanp, who reported this and prototyped the same fix on a branch in their fork.
Server Details
fetch,gitMotivation and Context
The stale comment tells Docker users to pass an option that does not exist. See #5483.
How Has This Been Tested?
The change has nothing a client can observe, so the evidence is a targeted probe:
grep -rn "db-path\|db file" src/*/Dockerfile src/*/README.mdfinds nothing (exit 1).docker build --check src/fetchanddocker build --check src/gitboth printCheck complete, no warnings found.npm run local:gateexits 0. The git comment's wording was amended once while the gate was running; that edit touches only a Dockerfile comment, which no gate stage parses.Breaking Changes
None. Client configurations do not change.
Types of changes
Checklist
npm run changeset) if this changes what a TypeScript server publishes (not applicable: Python servers only)🤖 Generated with Claude Code