Skip to content

fix(docker): correct stale --db-path comments in fetch/git Dockerfiles and clarify git README #5483

New issue
New issue
Closed
#5531
Closed
fix(docker): correct stale --db-path comments in fetch/git Dockerfiles and clarify git README#5483
#5531
Assignees
cliffhall
Labels
documentationImprovements or additions to documentationserver-fetchReference implementation for the Fetch MCP server - src/fetchserver-gitReference implementation for the Git MCP server - src/gitv2
Milestone
v2.5.0

Description

@EduardoAndradeSLima
EduardoAndradeSLima
opened on Nov 6, 2026

Which server?

More than one server

Server version

n/a

How did you run the server?

Docker image

Transport

Not applicable (a repository-level report)

Protocol era

Not applicable (a repository-level report)

MCP client and version

n/a

Operating system and runtime

Docker / Linux

Server configuration

No response

Steps to reproduce

  1. Inspect src/fetch/Dockerfile at line 38:
    # when running the container, add --db-path and a bind mount to the host's db file
  2. Inspect src/git/Dockerfile at line 41:
    # when running the container, add --db-path and a bind mount to the host's db file
  3. Inspect src/git/README.md at line 204:
    Mentions that "The image runs as root, so it goes at /root/.gitconfig:", whereas the Dockerfile sets up the non-root app user (useradd -rUM -s /usr/sbin/nologin app).

Expected behavior

  • src/fetch/Dockerfile: The --db-path comment should be removed as the fetch server is an HTTP client without database arguments or host DB mounts.
  • src/git/Dockerfile: The comment should refer to bind-mounting the host repository directory, not a database path.
  • src/git/README.md: Documentation should accurately reflect the container's user execution model.

Actual behavior

Both Dockerfiles retain a copy-pasted comment from database servers referencing --db-path and database mounting.

Logs or error output

Already prototyped a fix?

In src/fetch/Dockerfile:
Remove the outdated comment on line 38 (# when running the container, add --db-path and a bind mount to the host's db file).

In src/git/Dockerfile:
Update line 41 to reference mounting the host's git repository directory.

Before you submit

  • I searched existing issues and this is not a duplicate.
  • This is not a security vulnerability report (those go through the private advisory form).

Activity

  1. EduardoAndradeSLima
    added
    bugSomething isn't working
    v2
    on Nov 6, 2026

  2. muhammedriswanp commented on Nov 9, 2026

    @muhammedriswanp
    muhammedriswanp
    on Nov 9, 2026

    Hi! I have prepared a fix for this on a branch based on v2/main:
    https://github.com/muhammedriswanp/servers/tree/fix/docker-comments-and-git-readme-5483

    Summary of changes:

    • Removed the stale --db-path comment in src/fetch/Dockerfile
    • Updated the comment in src/git/Dockerfile to refer to mounting the host's git repository directory
    • Checked src/git/README.md (the line referencing the non-root app user and /home/app/.gitconfig is already up to date on v2/main)

    Since direct PR creation is restricted to collaborators, please let me know if a maintainer can pull these changes or how you would prefer to proceed!

  3. EduardoAndradeSLima commented on Nov 9, 2026

    @EduardoAndradeSLima
    EduardoAndradeSLima
    on Nov 9, 2026
    Author

    Hi @muhammedriswanp, thanks for looking into this and preparing the fix!

    Just as a heads-up, per this repository's CONTRIBUTING.md, external pull requests are not accepted and maintainers handle PRs internally. Since all details are already documented in this issue and you've shared your branch with the fix, a maintainer will be able to review and apply it directly.

    Thanks again for your contribution!

  4. muhammedriswanp commented on Nov 9, 2026

    @muhammedriswanp
    muhammedriswanp
    on Nov 9, 2026 via email
  5. cliffhall
    added
    documentationImprovements or additions to documentation
    server-fetchReference implementation for the Fetch MCP server - src/fetch
    server-gitReference implementation for the Git MCP server - src/git
    and removed
    bugSomething isn't working
    on Nov 10, 2026

  6. cliffhall commented on Nov 10, 2026

    @cliffhall
    cliffhall
    on Nov 10, 2026
    Member

    Triage: Priority Low (total 2)

    • Severity 1: stale comments in the fetch and git Dockerfiles, and a README line about the container user; nothing behaves wrongly
    • Urgency 1: no time pressure
    • Bonuses: none (relabeled documentation from bug)

    Board: Servers V2 (#43), Status Incoming, awaiting maintainer review (no milestone yet).

  7. modelcontextprotocol
    deleted a comment from HhH666-ux on Nov 10, 2026
  8. modelcontextprotocol
    deleted a comment from HhH666-ux on Nov 10, 2026
  9. cliffhall
    added this to the v2.5.0 milestone on Nov 10, 2026
  10. cliffhall
    self-assigned this
    on Nov 12, 2026
  11. cliffhall
    linked a pull request that will close this issuedocs(docker): drop the stale --db-path comments in the fetch and git Dockerfiles #5531on Nov 12, 2026
  12. cliffhall
    closed this as completedon Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentationserver-fetchReference implementation for the Fetch MCP server - src/fetchserver-gitReference implementation for the Git MCP server - src/gitv2

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions