fix: preserve DCR client info on disconnect to avoid re-registration errors#1121
Open
peschee wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: preserve DCR client info on disconnect to avoid re-registration errors#1121peschee wants to merge 1 commit intomodelcontextprotocol:mainfrom
peschee wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
…errors Stop clearing dynamically registered client information from sessionStorage in clear(). The DCR-obtained client_id remains valid at the IDP, so discarding it on disconnect/reconnect forces an unnecessary re-registration that IDPs like Keycloak reject.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clear()inauth.tswas wipingclientInformationfrom sessionStorage along with tokens and code verifier.clear(). Only tokens and transient OAuth state are cleared, preserving the still-valid DCR client credentials for reconnection.Test plan
npm run build-clientpassescd client && npm run lintpasses