fix: clear cached DCR client on Guided OAuth Flow and add clear dialog#1123
Open
peschee wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix: clear cached DCR client on Guided OAuth Flow and add clear dialog#1123peschee wants to merge 2 commits intomodelcontextprotocol:mainfrom
peschee wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
…errors Stop clearing dynamically registered client information from sessionStorage in clear(). The DCR-obtained client_id remains valid at the IDP, so discarding it on disconnect/reconnect forces an unnecessary re-registration that IDPs like Keycloak reject.
Guided OAuth Flow Step 2 was showing cached client_id from sessionStorage without making an actual DCR network request. Now clears the cached DCR client info when starting the Guided flow so Step 2 always performs a fresh registration. Quick OAuth Flow is unaffected. Also replaces the immediate "Clear OAuth State" action with a confirmation dialog that offers an optional checkbox to also clear the registered DCR client information. Fixes pre-existing test parse error (Babel `as never` in mock factory).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client_idfrom sessionStorage without making an actual DCR network request. Users saw stale data and couldn't verify that DCR was working correctly.as neverin mock factory).Test plan
npm run build-clientpassescd client && npm run lintpassescd client && npm testpasses (new and existing tests)