-
Notifications
You must be signed in to change notification settings - Fork 643
Add client completion notification and details #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stephentoub
wants to merge
3
commits into
modelcontextprotocol:main
Choose a base branch
from
stephentoub:completiondetails
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+630
−31
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
21 changes: 21 additions & 0 deletions
21
src/ModelContextProtocol.Core/Client/ClientCompletionDetails.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| namespace ModelContextProtocol.Client; | ||
|
|
||
| /// <summary> | ||
| /// Provides details about why an MCP client session completed. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// <para> | ||
| /// Transport implementations may return derived types with additional strongly-typed | ||
| /// information, such as <see cref="StdioClientCompletionDetails"/>. | ||
| /// </para> | ||
| /// </remarks> | ||
| public class ClientCompletionDetails | ||
| { | ||
| /// <summary> | ||
| /// Gets the exception that caused the session to close, if any. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// This is <see langword="null"/> for graceful closure. | ||
| /// </remarks> | ||
| public Exception? Exception { get; set; } | ||
| } |
15 changes: 15 additions & 0 deletions
15
src/ModelContextProtocol.Core/Client/HttpClientCompletionDetails.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| using System.Net; | ||
|
|
||
| namespace ModelContextProtocol.Client; | ||
|
|
||
| /// <summary> | ||
| /// Provides details about the completion of an HTTP-based MCP client session, | ||
| /// including sessions using the legacy SSE transport or the Streamable HTTP transport. | ||
| /// </summary> | ||
| public sealed class HttpClientCompletionDetails : ClientCompletionDetails | ||
| { | ||
| /// <summary> | ||
| /// Gets the HTTP status code that caused the session to close, or <see langword="null"/> if unavailable. | ||
| /// </summary> | ||
| public HttpStatusCode? HttpStatusCode { get; set; } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
src/ModelContextProtocol.Core/Client/StdioClientCompletionDetails.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| namespace ModelContextProtocol.Client; | ||
|
|
||
| /// <summary> | ||
| /// Provides details about the completion of a stdio-based MCP client session. | ||
| /// </summary> | ||
| public sealed class StdioClientCompletionDetails : ClientCompletionDetails | ||
| { | ||
| /// <summary> | ||
| /// Gets the process ID of the server process, or <see langword="null"/> if unavailable. | ||
| /// </summary> | ||
| public int? ProcessId { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Gets the exit code of the server process, or <see langword="null"/> if unavailable. | ||
| /// </summary> | ||
| public int? ExitCode { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Gets the last lines of the server process's standard error output, or <see langword="null"/> if unavailable. | ||
| /// </summary> | ||
| public IReadOnlyList<string>? StandardErrorTail { get; set; } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.