Add client completion notification and details#1368
Open
stephentoub wants to merge 3 commits intomodelcontextprotocol:mainfrom
Open
Add client completion notification and details#1368stephentoub wants to merge 3 commits intomodelcontextprotocol:mainfrom
stephentoub wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
This was referenced Feb 24, 2026
src/ModelContextProtocol.Core/Client/StdioClientCompletionDetails.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
previously approved these changes
Feb 24, 2026
halter73
previously approved these changes
Feb 24, 2026
Contributor
halter73
left a comment
halter73
left a comment
There was a problem hiding this comment.
I would like to see this implemented for stateful Streamable HTTP when there are 404s as well, but I think this is already a nice improvement even without that part. I have a small preference for the abstract Completion property over the method, but I don't care too much either way on that.
src/ModelContextProtocol.Core/Client/SseClientSessionTransport.cs
Outdated
Show resolved
Hide resolved
Introduce a new mechanism for reporting MCP client session completion details, including both graceful and error terminations. Add a Completion property to McpClient, exposing a `Task<ClientCompletionDetails>` that completes with details about session closure. Implement extensible completion details (including StdioClientCompletionDetails for stdio transports) and propagate them via a new internal TransportClosedException.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
stephentoub
dismissed stale reviews from halter73 and eiriktsarpalis
via
860e132
stephentoub
force-pushed
the
completiondetails
branch
from
cedcddc to
860e132
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new mechanism for reporting MCP client session completion details, including both graceful and error terminations. Add a Completion property to McpClient, exposing a
Task<ClientCompletionDetails>that completes with details about session closure. Implement extensible completion details (including StdioClientCompletionDetails for stdio transports) and propagate them via a new internal TransportClosedException.Closes #1332
Closes #438