Skip to content

Makefile: fix testing and building of subpackages #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaJeztah merged 1 commit into from
Sep 9, 2026
Merged

Makefile: fix testing and building of subpackages #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ clean:
$(RM) */coverage.txt

.PHONY: foreach
foreach: ## Run $(CMD) for every package.
foreach: ## Run $(CMD) for every module.
@if test -z '$(CMD)'; then \
echo 'Usage: make foreach CMD="commands to run for every package"'; \
echo 'Usage: make foreach CMD="commands to run for every module"'; \
exit 1; \
fi
set -eu; \
Expand All @@ -25,7 +25,7 @@ foreach: ## Run $(CMD) for every package.

.PHONY: test
test: test-local
test: CMD=go test $(RUN_VIA_SUDO) -v -coverprofile=coverage.txt -covermode=atomic .
test: CMD=go test $(RUN_VIA_SUDO) -v -coverprofile=coverage.txt -covermode=atomic ./...
test: foreach

# Some modules in this repo have interdependencies:
Expand All @@ -40,15 +40,15 @@ test-local:
@set -eu; if printf '%s\n' $(PACKAGES) | grep -qx mount && \
printf '%s\n' $(PACKAGES) | grep -qx mountinfo; then \
echo 'replace github.com/moby/sys/mountinfo => ../mountinfo' | cat mount/go.mod - > mount/go-local.mod; \
cd mount && go mod tidy $(MOD) && go test $(MOD) $(RUN_VIA_SUDO) -v .; \
cd mount && go mod tidy $(MOD) && go test $(MOD) $(RUN_VIA_SUDO) -v ./...; \
$(RM) mount/go-local.*; \
else \
echo "SKIP: mount local dependency test requires mount and mountinfo"; \
fi
@set -eu; if printf '%s\n' $(PACKAGES) | grep -qx atomicwriter && \
printf '%s\n' $(PACKAGES) | grep -qx sequential; then \
echo 'replace github.com/moby/sys/sequential => ../sequential' | cat atomicwriter/go.mod - > atomicwriter/go-local.mod; \
cd atomicwriter && go mod tidy $(MOD) && go test $(MOD) $(RUN_VIA_SUDO) -v .; \
cd atomicwriter && go mod tidy $(MOD) && go test $(MOD) $(RUN_VIA_SUDO) -v ./...; \
$(RM) atomicwriter/go-local.*; \
else \
echo "SKIP: atomicwriter local dependency test requires atomicwriter and sequential"; \
Expand All @@ -70,6 +70,6 @@ cross:
export GOOS=$${osarch%/*} GOARCH=$${osarch#*/}; \
echo "# building for $$GOOS/$$GOARCH"; \
for p in $(PACKAGES); do \
(cd $$p; go build .); \
(cd $$p; go build ./...); \
done; \
done
Loading