Makefile: fix testing and building of subpackages - #258
Merged
Merged
Conversation
The Makefile iterates over modules, but its test and cross-build commands only operated on the package at each module root. Use `./...` so subpackages are included in tests, local dependency tests, and cross-platform builds. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
There was a problem hiding this comment.
🟢 Approval recommended
The functional changes are correct; only a minor usage-message inconsistency remains.
Pull request overview
Updates module-wide Makefile workflows to include all subpackages.
Changes:
- Tests root and nested packages with
./.... - Extends local-dependency tests and cross-builds to subpackages.
- Clarifies that
foreachiterates over modules.
File summaries
| File | Description |
|---|---|
| Makefile | Expands testing and cross-building to module subpackages. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vvoland
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Makefile iterates over modules, but its test and cross-build commands only operated on the package at each module root.
Use
./...so subpackages are included in tests, local dependency tests, and cross-platform builds.