Repository navigation
Splitting _brain.py into multiple modules (phase 6) - #14417
Merged
Merged
Conversation
Member
Screenshot and save_movie combine the 3D scene with another GUI element (potentially). I think we can allow them as exceptions |
larsoner
approved these changes
Oct 15, 2026
larsoner
left a comment
larsoner
left a comment
Member
There was a problem hiding this comment.
Pushed a tiny commit to fix a failing test due to this PR plus one due to a failure in main. Marking for squash+merge-when-green, thanks in advance @payamsash !
Merged
larsoner
enabled auto-merge (squash)
October 15, 2026 17:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Sixth phase of #14331 and following #14410.
What does this implement/fix?
After this,
_brain.pycalls no time-viewer methods. What's left is thewidgets/time_viewersetup in__init__, andscreenshot/save_movie(time_viewer=True).@larsoner how would you suggest to handle
screenshot/save_movie(time_viewer=True)for the next PR?