Repository navigation
fix for neo 0.14.6 - #14423
Merged
Merged
fix for neo 0.14.6#14423
Conversation
larsoner
approved these changes
Oct 15, 2026
Member
|
Doc error can be ignored it's being fixed in #14417 |
Contributor
Author
Contributor
Author
|
@larsoner argh these CI are going to fail because of the global rng test errors and the doc typo errors that you fixed in #14417, and your CI's over at #14417 are going to fail because of the fixes needed here. Do you want to force merge this one or do you want me to cherry-pick your fixes from #14417? |
Member
|
Neither is necessary... let's just let CIs settle here, I'll merge #144417 manually, then restart CIs here to make sure things are really green |
Member
|
(oh sorry yes you suggested force-merge... yes I'll force-merge one or the other) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for error's showing up in #14413 . python-neo changed the way they handle recording gaps to raise by default, and introduced a new parameter gap_tolerance_ms