Skip to content

.NET: Don't add OpenAIResponses as part of Dev UI #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

.NET: Don't add OpenAIResponses as part of Dev UI #1977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions dotnet/src/Microsoft.Agents.AI.DevUI/DevUIExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ public static IHostApplicationBuilder AddDevUI(this IHostApplicationBuilder buil
{
ArgumentNullException.ThrowIfNull(builder);
builder.Services.AddOpenAIConversations();
builder.Services.AddOpenAIResponses();

return builder;
}
Expand All @@ -34,7 +33,6 @@ public static IEndpointConventionBuilder MapDevUI(
group.MapDevUI(pattern: "/devui");
group.MapEntities();
group.MapOpenAIConversations();
Copy link
Member

@jeffhandley jeffhandley Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably, we should remove builder.Services.AddOpenAIConversations(); and group.MapOpenAIConversations(); too if we follow this logic; right?

Ideally MapDevUI would validate that its needed services and mappings were in place and throw an InvalidOperationException if not. But I think that could come later.

Copy link
Member Author

@danroth27 danroth27 Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think so. And agreed on providing a good error diagnostic.

Copy link
Member Author

@danroth27 danroth27 Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think MapEntites() though is more Dev UI specific.

group.MapOpenAIResponses();
return group;
Copy link
Member

@ReubenBond ReubenBond Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also be adding the bits we remove to dotnet\samples\GettingStarted\DevUI\DevUI_Step01_BasicUsage\Program.cs so that the sample still works

}

Expand Down
Loading