.NET: Don't add OpenAIResponses as part of Dev UI #1977
Conversation
You should be able to add and remove Dev UI without impacting your other production endpoints.
github-actions
bot
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR removes OpenAI Responses API support from the DevUI configuration, simplifying the DevUI to focus solely on Conversations functionality.
- Removes
AddOpenAIResponses()service registration from DevUI setup - Removes
MapOpenAIResponses()endpoint mapping from DevUI routing - Retains OpenAI Conversations API support for the DevUI
| var group = endpoints.MapGroup(""); | ||
| group.MapDevUI(pattern: "/devui"); | ||
| group.MapEntities(); | ||
| group.MapOpenAIConversations(); |
There was a problem hiding this comment.
Presumably, we should remove builder.Services.AddOpenAIConversations(); and group.MapOpenAIConversations(); too if we follow this logic; right?
Ideally MapDevUI would validate that its needed services and mappings were in place and throw an InvalidOperationException if not. But I think that could come later.
There was a problem hiding this comment.
Yeah, I think so. And agreed on providing a good error diagnostic.
There was a problem hiding this comment.
I think MapEntites() though is more Dev UI specific.
|
There are lots of DI-related APIs that add in necessary dependencies. Why is this different? |
@stephentoub With DI it's pretty easy to make the Add methods idempotent. Unfortunately, that's harder to do with Map methods in ASP.NET Core that add endpoints. |
| group.MapEntities(); | ||
| group.MapOpenAIConversations(); | ||
| group.MapOpenAIResponses(); | ||
| return group; |
There was a problem hiding this comment.
We should also be adding the bits we remove to dotnet\samples\GettingStarted\DevUI\DevUI_Step01_BasicUsage\Program.cs so that the sample still works
|
This should be closed in favor of (#2014) .NET: DevUI - Do not automatically add/map OpenAI services/endpoints |
5 participants
You should be able to add and remove Dev UI without impacting your other production endpoints. This is the pattern used by Swagger UI, where you need to separate set up the OpenAPI endpoint that the Swagger UI depends on.