Repository navigation
docs(playbooks): tighten three skill bodies to the skill criteria - #11977
Conversation
Cut filler, intensifiers and restated sentences from the boris, fable-5 and skill-authoring bodies and their reference and context files. Frontmatter, headings, numbers, links, code spans, quotes, pointer records and vendored upstream copies are unchanged; repo-sweep and update are untouched. Refs: #6572 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94fa633a1b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
claude-security-review reviewed Security review (incremental since beab815): no issues foundThis review covers only the change since beab815: one line in the changelog fragment What changed: the changelog entry no longer lists Security surface: none.
The other 11 files in this PR are unchanged since the last reviewed commit and were reviewed then. critical-findings: 0 |
|
claude-review reviewed Incremental review (beab815 → 033ad18)Scope: What changed: The changelog fragment no longer lists Check against the rest of the PR:
Closing issue #6572: The PR body has a per-skill decision table and names each unmeasured skill with its reason. That covers the issue's "Done when" items as far as this lane can check. The "measured" criterion rests on the owner decision linked from the PR body; the lane cannot check that decision. Note (not a finding): The PR title still says "tighten three skill bodies", but the body and this fragment now say two. The title becomes the squash-commit subject, so the author may want to update it. No findings in this increment. |
The runbook cuts a rule's stated reason only when an outcome case covers the behavior it explains, and playbooks has no cases. Restore the seven rationale sentences (fable-5 SKILL, calibration, planning x2; boris automation, foundations; skill-authoring verification loops); the filler deletions stay. Refs: #6572 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Reply to the claude-review summary on
|
The fable-5 pack is doctrine Fable wrote for itself; /playbooks:update regenerates it only on a Fable model-version change, and #4346 reserves that regeneration for a Fable 5.1 session because another model cannot re-author it. Restore every fable-5 file to main's text; boris and skill-authoring keep their wording cuts. Refs: #6572, #4346 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closes #6572
Summary
Rewrites the house-owned parts of two
playbooksskills (boris,skill-authoring) to the skill criteria, wording only: 11 files, 0-2% each. Synced upstream content (boris/vendor/,skill-authoring/vendor/, the SKILL.md sync metadata) and quoted upstream wording (Boris's and Thariq's words) are untouched. No rule, threshold, number, example, identifier, cross-reference, frontmatter, code block or script changed.Fix
Per-skill decision table:
/playbooks:updateregenerates it only on a Fable model-version change, and #4346 reserves that for a Fable 5.1 session (an earlier commit here reworded it; reverted to main's text)Deliberately unchanged inside the three:
skill-authoring/reference/skill-criteria.md(the house contract; six frozen eval cases cite its line ranges),rewrite-a-plugin.md(numbered runbook), and the boris chapters that are mostly upstream wording.Unmeasured, and why: the plugin has no outcome eval cases or probes, so the two skills ship on the two-labeler meaning diff alone under the owner's Q7 decision for this rollout (recorded on #6476), which relaxes the AGENTS.md eval-evidence rule for wording-only cuts. Descriptions are byte-identical, so triggering is untouched. The issue's "approve the eval spend" step does not apply (no eval ran; subscription usage is capacity, not cost).
Verification
docs-hygiene:compare-labeler, 2 runs per changed skill, before copy fromgit archive origin/main: boris and skill-authoring PASS. Seven rationale sentences the review flagged are restored (rationale is cut only when a case covers it).boris/scripts/update.test.sh42/42,skill-authoring/scripts/update.test.sh32/32; skill-quality FAIL/WARN counts identical before and after for all five skills; fable-5 is byte-identical to main.rewrite-a-plugin.md) touches no rewritten file.Related
🤖 Generated with Claude Code