Repository navigation
feat(work-items): route an idea issue to an interview before triage explores it - #11893
melodic-automation-lanes[bot] wants to merge 2 commits into
Conversation
Lane-Activity: work-resolve-issue/resolve-issue
|
claude-security-review reviewed Security review (incremental, 8175049 → 5e24718)No security issues found in this change. I read every hunk of the two files in scope in
None of the trusted-path globs matches either file. Neither file is a trust control or a plugin manifest. The PR context contains no embedded instructions aimed at this lane. critical-findings: 0 |
| `needs-spec` that "Status and provenance labels" in | ||
| [`context/apply-outcome.md`](context/apply-outcome.md) defines. Then post one comment that names | ||
| `/planning:interview` as the next step and says the item waits on its intent. If the comment | ||
| cannot be posted, apply no label. Then, in one label edit, apply `needs-spec` and remove the raw |
There was a problem hiding this comment.
A parked idea issue still shows up on the autonomous frontier. wit_filter_frontier --autonomous (tools/work-item-tracker/lib/frontier.sh:41-45) drops an item only if it has the human-gated label or a label in the human floor. The floor's status list (lib/labels.sh:40-43) has status: needs-decision and status: needs-info but not needs-spec.
This route applies needs-spec with no role, status: or work-class label. So an item parked here (e.g. this eval's #1 after the park) is listed by list-frontier --autonomous. The needs-info and needs-decision parks are kept off it.
An attended /work-items:work run picking from that frontier can then start building something whose intent this paragraph says can't be judged yet. The label-path lanes still need the autonomous-eligible label, so they are not affected.
The PR body leaves this as a follow-up. Adding needs-spec to the floor, with a frontier test, would make the park hold like the other two. If it stays out of scope, a sentence here or a follow-up issue would keep the gap on record.
claude-lane: claude-review
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: plugins/work-items/tools/work-item-tracker/lib/frontier.sh:41, plugins/work-items/tools/work-item-tracker/lib/labels.sh:40, plugins/work-items/skills/triage/SKILL.md:266
The claim holds. wit_filter_frontier with autonomous=true drops an item only for the human-gated label or a floor label, and WIT_HUMAN_FLOOR_STATUS_LABELS lists status: needs-decision and status: needs-info but not needs-spec. The idea-issue route applies needs-spec with no role or status label, so a parked item stays on the autonomous frontier. The real fix is to add needs-spec to the human floor in labels.sh and add a frontier test. That is shared tracker infrastructure used by every frontier caller, and the review-thread scope check refuses labels.sh for this lane. Leaving the thread open for a person to choose: widen this PR to change the floor, or file a follow-up and note the gap in the skill.
There was a problem hiding this comment.
pr-unblock / adjudicate-feedback: the finding stands
A fresh-context adjudicator read the review comment, the locations both sides cited and the code at 8175049c0854ba847d04320baf1ffed120de8711, without the fixing lane's reasoning, and found that the finding holds. The next address-feedback round fixes it; a round that leaves this thread open again ends the lane in a failing status.
Evidence: plugins/work-items/tools/work-item-tracker/lib/frontier.sh:41, plugins/work-items/tools/work-item-tracker/lib/labels.sh:40, plugins/work-items/skills/triage/SKILL.md:266
There was a problem hiding this comment.
pr-fix lane: please fix this finding. Add needs-spec to the human floor in plugins/work-items/tools/work-item-tracker/lib/labels.sh (the status list at lines 40-43 holds only status: needs-decision and status: needs-info), plus a frontier test showing that list-frontier --autonomous drops a needs-spec item. That way the idea-issue park holds like the other two. The change is in the same plugin, so it belongs in this PR.
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: plugins/work-items/tools/work-item-tracker/lib/labels.sh:40, plugins/work-items/tools/work-item-tracker/lib/frontier.sh:43, plugins/work-items/tools/work-item-tracker/lib/frontier.test.sh:139
The direction asks for two changes: add needs-spec to the human floor in lib/labels.sh, and add a frontier test showing that the autonomous frontier drops a needs-spec item. The finding still holds at this head. WIT_HUMAN_FLOOR_STATUS_LABELS (labels.sh:40-43) lists only status: needs-decision and status: needs-info. wit_filter_frontier (frontier.sh:30 and 41-45) drops an autonomous item only for the human-gated label or a floor label, so a bare needs-spec item stays on the autonomous frontier. labels.sh is in this lane's scope because the direction names it. The test is not. Its home is lib/frontier.test.sh, where the STATUS fixture at lines 137-148 already covers the other two status parks, and the review-thread scope check refuses that file: it is a .sh file outside this thread's directory and is not a path the direction names. Every other frontier test in the tracker is also a .sh file under tools/work-item-tracker, so none is in scope either. Landing the floor change without the test would ship half of the direction and leave a behavior change untested. Putting a frontier test under skills/triage just to pass the scope check would put it in the wrong place. So this round makes no edit. To let the next round do both parts, post the fix request again and name plugins/work-items/tools/work-item-tracker/lib/frontier.test.sh as well as labels.sh. With both in scope, the fix is: add needs-spec to the floor list in labels.sh (it is a bare Meta label, not a status: value, so the comment above the list should say so), add a needs-spec item to the STATUS fixture asserting that the autonomous frontier drops it and the default frontier keeps it, and add needs-spec to the floor sentence in CONTRACT.md at lines 306-307.
|
claude-review reviewed Incremental review (8175049 → 5e24718): no findings. I read every hunk in both files that changed in this range.
I ran no checks myself (this lane has no shell). The PR's statements about I found no embedded instructions in the PR context. |
|
The unattended merge path armed native auto-merge at head |
Lane-Activity: pr-unblock/address-feedback Lane-Thread: PRRT_kwDOTCGFQM6yYIKA Lane-Thread: PRRT_kwDOTCGFQM6yYIKF
|
pr-unblock / address-feedback finished round 1 of max 4 on 5e24718. |
|
The pr-unblock lane stopped
When a retry on this head can change the outcome, the lane runs one on its own, up to its per-head cap, and edits this comment if it stops again; a run that does not stop clears the status. When no retry can (a review thread the lane does not take or settle, or a failing check after the retries are spent), a person resolves the threads or gets the checks green, then dispatches the workflow below: that run finds the cause gone and clears the status. On a pull request the lanes App opened, the dispatchers start that run once per stop; on any other, a person does. A new commit to the branch starts clean. To run it again on this head now, dispatch the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=11893 -f activity=address-feedback |
|
Unattended merge: native auto-merge leaves this pull request unarmed at head |
|
Hold: replaced by an owner-login PR because the fix lane cannot take the open finding. Releases when: the replacement merges and this PR is closed. |
|
pr-unblock / address-feedback finished round 2 of max 4 on 5e24718. |
|
Superseded by #11918, which carries this change plus the needs-spec human-floor fix and its frontier test. |
Closes #11869
Summary
Opened by the work-resolve-issue lane. The run's own summary:
Not verified
Fix
Verification
The runner ran each check from the base copy against 8175049:
The run reports:
Left out: the items under Not verified.
Related
#11869