Skip to content

docs(work-items): remove the manual C3 ratification check from work-loop - #11844

Merged
kyle-sexton merged 3 commits into
mainfrom
docs/work-items-c3-ratification-7226
Nov 1, 2026
Merged

kyle-sexton merged 3 commits into
mainfrom
docs/work-items-c3-ratification-7226

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Closes #7226

Summary

Owner-login replacement for #11799, which pr-merge's risk gate cannot read (its force-push history is past one page). The diff is identical to #11799's head 27cd962, merged with --no-ff onto main.

The work-resolve-issue lane's summary from #11799:

Per the recorded decision on #7226 (2026-10-31), this deletes the 'Manual check for the C3 ratification gate'. That check was the only content in plugins/work-items/skills/work-loop/AGENTS.md, so the file is gone, along with its CLAUDE.md, whose only line was AGENTS.md, and its row in the generated instruction-placement index in the root AGENTS.md. The work-loop SKILL.md no longer says that reference/c3-ratification-queue.md owns the manual check. That file never held one. The host run on the issue already met criteria 1 and 2, and #11306 merged the case 6 fix, so this PR finishes the issue.

Not verified

  • tidy skipped: the change touches the root AGENTS.md, which is a listed shared path, so it falls outside the tidy cutoffs
  • The changelog fragment was written by hand in the helper's format; check-changelog-fragments accepts it
  • The CI-only checks check-affected lists (for example lychee-offline, evals-schema and docs-naming) and the checks it skipped are left to CI

Fix

  • plugins/work-items/skills/work-loop/AGENTS.md: deleted; its only section was the manual C3 ratification check
  • plugins/work-items/skills/work-loop/CLAUDE.md: deleted; its only line was AGENTS.md, which pointed at the deleted file
  • AGENTS.md: removed the work-loop AGENTS.md row from the generated instruction-placement rules index
  • plugins/work-items/skills/work-loop/SKILL.md: dropped 'this gate's manual check' from the list of what reference/c3-ratification-queue.md owns
  • .changes/work-items/work-resolve-issue-issue-7226-3b8e1f47.md: new patch changelog fragment that records the removal

Verification

Related

🤖 Generated with Claude Code

melodic-automation-lanes Bot and others added 3 commits November 1, 2026 02:56
Lane-Activity: work-resolve-issue/resolve-issue
Carries 27cd962 from
work-resolve-issue/issue-7226-41265414999-1 onto an owner-login branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 1, 2026 05:47
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T05:49:09.120578Z 52fbb7a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

claude-review reviewed 52fbb7abbdd6a91fce4eecfbd23dcfe41095002f: read 5 of 5 changed file(s); 0 finding(s), 0 as inline comments.

Code review: PR #11844, remove the manual C3 ratification check from work-loop

No findings. I read every hunk of all five changed files.

What the PR changes

  • plugins/work-items/skills/work-loop/AGENTS.md is deleted. Its only section was the manual C3 ratification check.
  • plugins/work-items/skills/work-loop/CLAUDE.md is deleted. Its only line was @AGENTS.md, so it would have pointed at a missing file.
  • The root AGENTS.md loses that file's row from the generated instruction-placement index. The table is still well-formed, and every remaining row points at a different surface.
  • In SKILL.md, the admission-gate pointer no longer says that reference/c3-ratification-queue.md owns "this gate's manual check". The sentence still reads correctly after the edit.
  • A new changelog fragment, bump: patch, records the removal under "Removed". This change only removes contributor docs and changes no runtime behaviour, so a patch bump fits.

Checks

  • Dangling references: I searched outside CHANGELOG history for work-loop/AGENTS.md, work-loop/CLAUDE.md and "manual check" across the repository and under plugins/work-items. The only hits were the new fragment and the lane input files. The one hit in plugins/work-items/CHANGELOG.md is history and should stay.
  • Closing issue test(work-items): run the new work-loop and attend-queue evals and a live C3 check #7226: The recorded decision comment sets this criterion: "plugins/work-items/skills/work-loop/AGENTS.md no longer holds the 'Manual check for the C3 ratification gate' section, and the file is removed if that leaves it with no other content." The PR meets it by deleting the file and the CLAUDE.md that imported it.
  • Path-scoped rule: .claude/rules/skill-bodies-state-current-rules.md matches SKILL.md. The edit only removes a clause and adds no volatile specifics, so it complies.
  • Plugin manifests: none changed.
  • Paved paths: none apply to this change.

Verification status

I did not run these checks; they are the author's claims. The author says:

I confirmed only that the edited index table is well-formed and that the repository search turned up no stale references.

Other notes

  • The PR description and issue comments contain no embedded instructions aimed at this review.
  • Trusted-path files touched: the root AGENTS.md, plus work-loop/AGENTS.md and work-loop/CLAUDE.md through the **/AGENTS.md and **/CLAUDE.md globs. All three changes are removals. None of them widens permissions or what a check lets through.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 52fbb7abbdd6a91fce4eecfbd23dcfe41095002f: read 5 of 5 changed file(s); 0 finding(s), 0 as inline comments.

Security review: no security issues found

Result: this pull request has no security issues.

I read all 5 changed files in .claude-lane/pr.diff. Two are on trusted paths, AGENTS.md and plugins/work-items/skills/work-loop/CLAUDE.md, and I read both in full.

What changed

  • plugins/work-items/skills/work-loop/AGENTS.md (deleted): its only content was a manual test procedure for contributors. It said to re-run the C3 ratification gate by hand after editing it, and to check that one kind=ratify-c3 comment and the human-gated label resulted.
  • plugins/work-items/skills/work-loop/CLAUDE.md (deleted): its only line was @AGENTS.md.
  • Root AGENTS.md: the matching row comes out of the generated instruction-placement index.
  • SKILL.md: one phrase is dropped from the list of what reference/c3-ratification-queue.md owns.
  • New patch changelog fragment recording the removal.

Instruction-surface check
This diff deletes a standing-instruction file, so I checked it against the instruction exception register. That file is present: docs/contracts/instruction-exception-register/README.md, which adopts the six Gate 0 classes.

  • Not a runtime guardrail. The removed text is a test step for contributors. It tells the model nothing about what to allow or refuse when the work-loop runs.
  • The C3 gate itself is untouched. It still lives in SKILL.md and reference/c3-ratification-queue.md. The admission-gate text kept around SKILL.md L417–L421 still requires reading the queue reference before writing comments or labels. It also still says a ratification recorded only in the issue body is never dispatch authority.
  • No protected class loses enforcement. Nothing in irreversible-action, secret-handling, data-integrity, external-publication, legal-compliance or agent-authority is left unchecked.
  • Nothing still points at the deleted file. I searched the work-loop skill for "manual check" and found no remaining references.

Trust controls: the diff touches no workflow, action, token, trusted-actor list, kill switch, merge hold or plugin manifest. Nothing is widened.

PR context: the description and issue text contain no embedded instructions aimed at this review.

critical-findings: 0

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 1, 2026
Merged via the queue into main with commit 7b6f439 Nov 1, 2026
69 checks passed
@kyle-sexton
kyle-sexton deleted the docs/work-items-c3-ratification-7226 branch November 1, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(work-items): run the new work-loop and attend-queue evals and a live C3 check

1 participant