Skip to content

docs(work-items): remove the manual C3 ratification check from work-loop - #11799

Closed
melodic-automation-lanes[bot] wants to merge 1 commit into
mainfrom
work-resolve-issue/issue-7226-41265414999-1
Closed

melodic-automation-lanes[bot] wants to merge 1 commit into
mainfrom
work-resolve-issue/issue-7226-41265414999-1

Conversation

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor

Closes #7226

Summary

Opened by the work-resolve-issue lane. The run's own summary:

Per the recorded decision on #7226 (2026-10-31), this deletes the 'Manual check for the C3 ratification gate'. That check was the only content in plugins/work-items/skills/work-loop/AGENTS.md, so the file is gone, along with its CLAUDE.md, whose only line was AGENTS.md, and its row in the generated instruction-placement index in the root AGENTS.md. The work-loop SKILL.md no longer says that reference/c3-ratification-queue.md owns the manual check. That file never held one. The host run on the issue already met criteria 1 and 2, and #11306 merged the case 6 fix, so this PR finishes the issue.

Not verified

  • tidy skipped: the change touches the root AGENTS.md, which is a listed shared path, so it falls outside the tidy cutoffs
  • The new-changelog-fragment helper refused to run because HEAD is detached. I wrote the fragment by hand in the same format, and check-changelog-fragments accepts it
  • The CI-only checks check-affected lists (for example lychee-offline, evals-schema and docs-naming) and the checks it skipped (changed-skills, typos, validate-plugins subchecks) are left to the PR's CI
  • git status also shows untracked dotfiles at the repo root (.bash_profile, .bashrc, .gitconfig, .idea, .mcp.json, .profile, .ripgreprc, .vscode, .zprofile, .zshrc). This run did not create them; they look like artifacts of the lane environment and should not go into the patch

Fix

  • plugins/work-items/skills/work-loop/AGENTS.md: deleted; its only section was the manual C3 ratification check
  • plugins/work-items/skills/work-loop/CLAUDE.md: deleted; its only line was AGENTS.md, which pointed at the deleted file
  • AGENTS.md: removed the work-loop AGENTS.md row from the generated instruction-placement rules index
  • plugins/work-items/skills/work-loop/SKILL.md: dropped 'this gate's manual check' from the list of what reference/c3-ratification-queue.md owns
  • .changes/work-items/work-resolve-issue-issue-7226-3b8e1f47.md: new patch changelog fragment that records the removal

Verification

The runner ran each check from the base copy against 27cd962:

  • scripts/check-changelog-fragments.sh --check: passed

The run reports:

  • check-changelog-fragments: all 5 fragments under .changes/ are valid (run before and after the review fix)
  • check-affected: 11 passed, 7 skipped, the rest left to CI, over the changed files (run before and after the review fix)
  • Grep for 'work-loop/AGENTS.md' and 'Manual check' outside CHANGELOG history: no remaining references
  • Fresh-context review subagent: the index edit matches what render-index.sh would generate (it lists files with git ls-files, skips a CLAUDE.md that only imports, and sorts rows with LC_ALL=C), and the SKILL.md sentence is accurate. It flagged one problem: the first fragment draft cited eval cases th
  • The lane run: https://github.com/melodic-software/claude-code-plugins/actions/runs/41265414999

Left out: the items under Not verified.

Related

#7226

Lane-Activity: work-resolve-issue/resolve-issue
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

claude-review reviewed 27cd96257a9fc98df97f0c4b789ec814598a69f4: read 5 of 5 changed file(s); 0 finding(s), 0 as inline comments.

Code review: PR #11799 (no findings)

I read every hunk of all 5 changed files, the PR context, and closing issue #7226.

What changed. The PR deletes the manual C3 ratification check. That check was the only content in plugins/work-items/skills/work-loop/AGENTS.md, so the file goes, along with the CLAUDE.md that only imported it. The PR also removes that file's row from the generated rules index in the root AGENTS.md, drops "this gate's manual check" from the work-loop SKILL.md admission-gate text, and adds a bump: patch changelog fragment.

Closing-issue criteria (#7226).

  • The 2026-10-31 decision comment adds one criterion: "plugins/work-items/skills/work-loop/AGENTS.md no longer holds the "Manual check for the C3 ratification gate" section, and the file is removed if that leaves it with no other content." This is met. The section was the file's only content, and the file is deleted.
    • No test could fail if this regressed. That is expected for a deletion of contributor documentation, so I am not raising it as a gap.
  • The PR context says the host-run comment on the issue already met criteria 1 and 2 (eval pass rates). This PR has no code for them.
  • Criterion 3 is resolved by the deletion above.
  • Criterion 4 (one follow-up issue per failing case) is outside this diff. The host run says only case 6 failed and that test(work-items): run the work-loop and attend-queue eval cases under plugin eval #11306 fixed it.

What I checked myself.

  • No dangling references. I searched the repository outside CHANGELOG files for work-loop/AGENTS.md, work-loop/CLAUDE.md, "manual check", skills/work-loop/** and "work-loop: contributor". The only hits are the new fragment and unrelated files.
  • SKILL.md edit is accurate. reference/c3-ratification-queue.md contains no "manual check" text, so the revised list of what that file owns now matches it.
  • Index row removal. Nothing else in the repository names the removed path glob. I did not run the index generator. The author says render-index.sh output matches the edit; that claim is unverified by me.
  • Changelog fragment. bump: patch fits removing contributor-only docs that ship no behaviour change. The text matches the diff. The author's report that check-changelog-fragments.sh --check passed is unverified by me.

Other notes.

  • Trusted paths. AGENTS.md (root), plugins/work-items/skills/work-loop/AGENTS.md and plugins/work-items/skills/work-loop/CLAUDE.md match trusted-path globs. I read each change in full. They only remove a documentation row and two documentation files, and they gate no automation.
  • Plugin manifests. No plugin.json or marketplace.json changed, so there are no manifest lines.
  • Embedded text. Neither the PR context nor the issue contains embedded instructions aimed at this review.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 27cd96257a9fc98df97f0c4b789ec814598a69f4: read 5 of 5 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #11799

No security issues found.

critical-findings: 0

What was reviewed

I read every part of all 5 changed files in .claude-lane/pr.diff:

  • .changes/work-items/work-resolve-issue-issue-7226-3b8e1f47.md: a new changelog fragment, plain prose.
  • AGENTS.md (trusted path **/AGENTS.md): removes one row from the generated instruction-placement index. That row pointed at the deleted work-loop/AGENTS.md.
  • plugins/work-items/skills/work-loop/AGENTS.md (trusted path): deleted.
  • plugins/work-items/skills/work-loop/CLAUDE.md (trusted path **/CLAUDE.md): deleted. Its only line was @AGENTS.md.
  • plugins/work-items/skills/work-loop/SKILL.md: one sentence changed. It no longer says that reference/c3-ratification-queue.md owns "this gate's manual check".

Instruction-surface lens

This change deletes a standing instruction, so it can't be skipped as prose-only. I checked the removed text against the protected classes in docs/contracts/instruction-exception-register/README.md (Gate 0: irreversible-action, secret-handling, data-integrity, external-publication, legal-compliance, agent-authority).

  • The deleted work-loop/AGENTS.md section was a step for contributors: after editing the C3 admission gate, re-run it by hand against an item and confirm the result. It was a way to test the gate, not a rule the agent follows at runtime. Deleting it changes nothing the work-loop agent may or may not do.
  • The runtime controls are unchanged. The admission gate's rules in SKILL.md (lines 417–421) still bind, including "The dispositions above bind regardless". So do the rules in reference/c3-ratification-queue.md: the marker ordering, the at-most-one marker rule and its author check, the role-label convergence, and the rule that a ratification recorded in an item's body is never dispatch authority. The SKILL.md edit only removes the pointer to the manual check, which that reference file never held. Nothing an agent is allowed to do changes.
  • The deleted rule matches no protected class, so it is not a finding.

Trust controls

None of the changed files is a trust control: no trusted-actor list, kill switch, token request or broker, merge hold, or .github/actions/ change. The trusted-path matches (AGENTS.md, CLAUDE.md) widen nothing.

PR context

The PR description and the issue comments contain no text telling the review to pass the PR, skip a check, or drop a finding. The PR description notes untracked dotfiles in the lane environment that were left out of the patch. They are not in the diff.

Spend

None. This change only edits docs and instructions.

@melodic-automation-lanes

melodic-automation-lanes Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor Author

Unattended merge: native auto-merge leaves this pull request unarmed at head 27cd96257a9fc98df97f0c4b789ec814598a69f4. The lanes clear this reason on their own; the next scheduled run judges it again.

pr-merge's gate holds it on its risk score (unreadable: RuntimeError: #11799 force pushes: unread or
  past one page)

@kyle-sexton kyle-sexton added the do-not-merge Hard merge gate: do not merge while applied. label Nov 1, 2026
@kyle-sexton

Copy link
Copy Markdown
Member

Hold: replaced by an owner-login PR because pr-merge's risk gate cannot read this PR's force-push history. Releases when: the replacement merges and this PR is closed.

@kyle-sexton

Copy link
Copy Markdown
Member

Superseded by #11844, which merged with the identical diff (patch-id 241af5795e).

@kyle-sexton kyle-sexton closed this Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Hard merge gate: do not merge while applied.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(work-items): run the new work-loop and attend-queue evals and a live C3 check

1 participant