refactor(native): split drawing internals#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cpp/ShapeRecognitioncpp/DrawingTypesand delta apply/revert helpers intocpp/DrawingHistoryStroke::ensureEraserCacheValidout of the shared drawing-type header and intocpp/DrawingTypes.cppcpp/PathRendererCrayon.cppandcpp/PathRendererCalligraphy.cpp, leaving shared variable-width/spline logic incpp/PathRenderer.cppSkiaDrawingEngineoperations into focused C++ translation units for selection, eraser, and rendering/export behavior while keeping the engine API unchangedValidation
npm run validateclang++ -std=c++20 -fsyntax-only cpp/*.cpp -I cpp -I node_modules/@shopify/react-native-skia/cpp/skia -I node_modules/@shopify/react-native-skia/cpp/skia/modules/pathops/includenpm audit --audit-level=moderatenpm --prefix example audit --audit-level=moderatefails with the existing Expo/PostCSS moderate advisory; confirmed the same failure onmainNo device/app run performed per request.