refactor: split large JS ink modules#28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContinuousEnginePoolinto a pool coordinator, pooled slot component, lifecycle helpers, and shared types so page assignment and engine mounting are easier to review.NativeInkCanvasnative-module discovery, public ref/prop types, and notebook bridge/export helpers into focused modules while preserving the existing public import path.ZoomableInkViewportpublic types into a dedicated module and added the new source directories to the packagefileslist so React Native source consumers still receive them.Test plan
npm installnpm --prefix example installnpm run typechecknpm test -- --runInBandnpm run buildnpm run test:native:smokenpm run test:example:typechecknpm run pack:dry-runnpm audit --audit-level=moderatenpm --prefix example audit --audit-level=moderatestill reports a pre-existing Expo/PostCSS advisory (GHSA-qx2v-qp2m-jg93) that requires separate dependency work outside this refactor.