Skip to content

refactor: split large JS ink modules#28

Merged
markm39 merged 1 commit into
mainfrom
refactor/split-ink-modules
May 14, 2026
Merged

refactor: split large JS ink modules#28
markm39 merged 1 commit into
mainfrom
refactor/split-ink-modules

Conversation

@markm39
Copy link
Copy Markdown
Contributor

@markm39 markm39 commented May 14, 2026

Summary

  • Split ContinuousEnginePool into a pool coordinator, pooled slot component, lifecycle helpers, and shared types so page assignment and engine mounting are easier to review.
  • Split NativeInkCanvas native-module discovery, public ref/prop types, and notebook bridge/export helpers into focused modules while preserving the existing public import path.
  • Moved ZoomableInkViewport public types into a dedicated module and added the new source directories to the package files list so React Native source consumers still receive them.

Test plan

  • npm install
  • npm --prefix example install
  • npm run typecheck
  • npm test -- --runInBand
  • npm run build
  • npm run test:native:smoke
  • npm run test:example:typecheck
  • npm run pack:dry-run
  • npm audit --audit-level=moderate
  • Simplify review completed; one local clarity nit was fixed before commit.
  • Security review completed for the changed code; no new bridge, payload, secret, or package exposure issues found.
  • App/device verification intentionally not run per maintainer request; maintainer will run it after this PR.
  • npm --prefix example audit --audit-level=moderate still reports a pre-existing Expo/PostCSS advisory (GHSA-qx2v-qp2m-jg93) that requires separate dependency work outside this refactor.

@markm39 markm39 merged commit 7ced4fd into main May 14, 2026
1 check passed
@markm39 markm39 deleted the refactor/split-ink-modules branch May 14, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant