fix(example): prevent duplicate Metro peer deps#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
example/node_modules@mathnotes/mobile-inkmapped to the local package source for example developmentWhy
Running the example from Xcode UI could load both
example/node_modulesand../node_modulescopies of React Native / gesture-handler / reanimated / worklets. That duplicated React Native dev environment setup and crashed with:TypeError: property is not writablewhile definingglobal.__FUSEBOX_REACT_DEVTOOLS_DISPATCHER__.Verification
node -c example/metro.config.jsnpm run typechecknpm run test:example:typechecknpm run test:example:export:iosnpx expo start --dev-client --clear --port 8101and confirmed it contains no package-root copies matching../node_modules/(react-native|react-native-gesture-handler|react-native-reanimated|react-native-worklets)Security / dependency note
npm audit --omit=dev --audit-level=moderatestill reports a pre-existing Expo/PostCSS advisory in the example dependency graph. The suggested automated fix is breaking and unrelated to this Metro resolver change, so this PR does not alter dependencies.