Skip to content

feat(M4-P0E1): one Studio GUI with isolated MU1/MU2/MU3 draft pagination - #343

Merged
masarray merged 19 commits into
mainfrom
feat/m4-p0e-studio-mu-pagination-model
Oct 26, 2026
Merged

masarray merged 19 commits into
mainfrom
feat/m4-p0e-studio-mu-pagination-model

Conversation

@masarray

Copy link
Copy Markdown
Owner

Code

  • Add typed Qt M4StreamScenarioModel with three independent, IED-qualified deep-copy MU draft states and predictable selection/snapshot lifecycle.
  • Expose SCD-backed qualified 4I4V/4kHz/4000-modulus/64-byte roster rows from existing SclProfileModel, preserving actual wire identity (MAC/APPID/svID/VLAN) instead of inventing identities.
  • Reuse one native Studio SignalMatrix+Waveform+Phasor composition across MU pages; per-MU frequency, eight channels/phase/quality, CT waveform shape and state retained across page changes.
  • Explicit M4 draft-only gating: disable existing legacy V1 START and SET paths to avoid silently applying an M4 draft to MU1 only; switching source SCD invalidates M4 drafts.
  • Add native arstack_m4_pages_harness and run on Linux, Windows Qt and paired native-preview CI.

Gate / follow-up

This is P0E1 UI state, not M4 SCD deployment. Actual MULTISV V2 serial transaction + firmware readback/reconnect/START, and final physical 3×4000fps P0F are still pending. P0E1 intentionally offers no fake START button. No change to M3.H.3 stable assets or single-SV wire protocol. Tracks #333.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T00:40:41.026307Z bde59a4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bde59a4c2e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/arstack_studio/qml/Main.qml
Comment thread apps/arstack_studio/qml/Main.qml Outdated
@masarray
masarray merged commit 6de01f3 into main Oct 26, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant