Repository navigation
D22 P7.6: read-only dual-ingress field diagnostic intake, bounded fail-closed tests - #759
Conversation
|
D22 verification checkpoint — exact Scope exactly 4 paths: two offline Python files, engineer how-to doc, one existing CI-P0 workflow addition. All runtime C#/XAML/engine locks, protected RC/main/stable, safety #753–756, Write #726/#716, SG7 #688 and GUI #732 unchanged. The validator is a read-only diagnostic consistency tool: its PASS is NEVER proof of physical IED, wire PCAP or release qualification. Fail-closed bounded capture/AP/target acceptance and negative-on-rerun semantics are new over historic #479. Historical #479 and #446 remain OPEN until actual RC adoption and field acceptance respectively. Full D22 source audit, exact CI evidence and D23 handoff. Keep PR DRAFT / no auto-merge, no CI retry spam. |
|
D23 source-build qualification COMPLETE at immutable HEAD
Decision: mark PR ready for review only, preserving a normal reviewer/required-check gate; DO NOT MERGE, DO NOT ENABLE AUTO-MERGE or close historical #479 until code is actually integrated. Retain #446/#520 physical acceptance and independent parallel-owner safety #753–756, Write #726/#716, SG7 #688, GUI #732. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc8712c30b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
D24 engineering checkpoint — exact-head P7.6 review hardeningFixed both concrete inline review findings in commit
Current exact-SHA GitHub Actions: CI P0 #40427176048 SUCCESS (24/24 P7.6 tests in 0.181s), CI P1 #40427176092 SUCCESS; Build ARSAS #40427176051 still in progress at checkpoint, awaiting its complete .NET/native/EXE/artifact gate. No manual reruns or new workflow. Read D24→D25 audit checkpoint. Do not merge automatically. GitHub App cannot inspect branch protection (403), owner approval is not established and no offline diagnostic PASS proves physical PCAP/R7/R10 device FAT. Preserve #479 open until this replacement is truly integrated; protect #757, safety #753–756, Write #726/#716, SG7 #688 and GUI #732. |
D25 exact-tree Windows qualification complete (no integration)Validated full Windows CI #40427176051: SUCCESS, attempt 1, all 36 displayed steps green. Windows tested PR synthetic merge Measured regression log: 2,987/2,987 ARSAS, 24/24 pinned engine, 6/6 packaged native bridge, 9/9 native CTest; portable EXE smoke, package sealing and all six unexpired artifacts succeeded. P0 #40427176048 and P1 #40427176092 also SUCCESS. No reruns; no new runner/job or source push. Exact artifact IDs and GitHub archive digests, tested synthetic-merge SHA vs PR HEAD proof, limitations and D26 gates: D25 checkpoint. Still not a merge approval. Both P2 discussions are resolved, but no APPROVE review; owner-only required checks inaccessible (403). Keep #759 open until explicit owner/ruleset decision. Do not merge protected RC #727/#729, retire historical #479, repin engine or publish stable from CI alone. No independent PCAP/physical IEC 61850 R7/R10 authority established. |
d2d0ca7
into
release/arsas-integrated-rc0-20261024
D22 — restore missing P7.6 local dual-ingress diagnostic consistency intake (from historical #479)
Source baseline: protected integrated RC #727/#729, exact
817c3910e8223fa2ac531a4426ada5d2d4bbbe50. HEAD:fc8712c30b01480ef58cc59fe344bbb15dabb523. DRAFT/DO NOT MERGE automatically.The historical #479 has three missing unique files in the RC: read-only field diagnostic verifier, offline safety tests, and engineer procedure. Rather than blindly merging the diverged old branch, D22 ports these three files onto the current RC and updates a fourth file, the existing lightweight CI-P0 workflow, to run their tests. No runtime C#/XAML, ARIEC/native engine, MMS association, control/write/GOOSE, ARDIREC, installer, pin, stable release or RC changes.
Verifier: parses one full local ARSAS Copy Diagnostic exact IED block. Requires semantic SHA match across Discovery/Open SCL, real per-target
ROUTEDsnapshot evidence, both BRCB+URCB, nonzero signal coverage, zero uncovered, complete bounded target inventory (only <=8 printed target slots per ingress), timezone-aware report receipt, and explicit single selected SCD AccessPoint. It rejects ambiguous/empty/forged/truncated reports and merely structural report matches. Uses 8 MiB input cap and atomically writes verdict; on failed rerun, stale earlier PASS is replaced byNOT_ESTABLISHED.Authority strictly bounded:
physicalVerification=false,wirePcapVerification=false. Even PASS means diagnostic text consistency ONLY; real wire PCAP, second association, E2E 7SX85/GE/F650 physical test still required. No local network or customer report uploaded.CI efficiency: 20 sanitized Python unittest cases in
scripts/test-p7-dual-ingress-diagnostic.py, routed into the existing UbuntuCI P0 Workflow Integrity(no new workflow, no new runner category). Source-level static check counted 20 tests and two trigger entries; actual CI result pending. Only one draft PR wave planned; do not rerun already green Windows CI without concrete error.Related #446 interoperability remains OPEN and original #479 remains OPEN until code is truly integrated/qualified; no physical release promotion. Parallel safety #753–#756, Write #726/#716, SG7 #688, IP GUI #732 and #757 CI-P4 draft must remain untouched.