Repository navigation
CI D26: bind COMTRADE canonical native shadow run to exact PR identity - #760
Merged
masarray merged 1 commit intoOct 27, 2026
Conversation
masarray
marked this pull request as ready for review
October 27, 2026 10:07
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
masarray
merged commit Oct 27, 2026
2b64e12
into
release/arsas-integrated-rc0-20261024
4 checks passed
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D26 — exact PR identity for COMTRADE native shadow comparison (review-only)
Base: protected integrated RC
817c3910e8223fa2ac531a4426ada5d2d4bbbe50; source HEAD:2c95d0c49d6d04ded18fa39bd4e431b85fa81e67. One isolated change wave, no main/stable/RC mutation.Root cause
The advisory
compare-ci-native-shadow.pypreviously selected canonicalBuild ARSASrun by PR head SHA + branch. Two PRs can share head SHA/branch but target different bases and yield distinct synthetic merge trees (e.g. integrated RC #727 and main release proposal #729). A newer run for a different PR can hide the correct source/engine proof and cause a misleading failure/timeout. GitHub runpull_requests[].head.shacan be mutable in old run metadata.Fix
GITHUB_EVENT_PATH, validate against CLI SHA/branch and bound file input.pull_requests[].numberin addition to head SHA, head branch, event/name and existing latest-run/attempt ordering.docs/audits/CI_P3J_D26_NATIVE_PR_RUN_IDENTITY.md. No workflow, WPF/engine, release/pin/installer or COMTRADE Windows CMake/CTest changes.Acceptance
DRAFT / DO NOT MERGE without owner required-check approval and exact-commit CI. Canonical Windows Build, independent COMTRADE Windows/native CTest, CI P0 and other relevant workflows must be evaluated at the exact candidate SHA/merge. Never infer physical FAT or deduplication authority from green CI. Preserve
independentWindowsCTestRetained=true,deduplicationAuthorized=false,releasePromotionAuthority=false.Protect PR #757 CI routing, #759 diagnostic, #753–#756 safety, #726/#716 Write, #688 SG7, #732 GUI, #727/#729 RC, and published stable v1.6.42. Parent issue #542 remains open.