Skip to content

CI D26: bind COMTRADE canonical native shadow run to exact PR identity - #760

Merged
masarray merged 1 commit into
release/arsas-integrated-rc0-20261024from
ci/p3j-d26-exact-pr-native-shadow-20261027
Oct 27, 2026
Merged

masarray merged 1 commit into
release/arsas-integrated-rc0-20261024from
ci/p3j-d26-exact-pr-native-shadow-20261027

Conversation

@masarray

Copy link
Copy Markdown
Owner

D26 — exact PR identity for COMTRADE native shadow comparison (review-only)

Base: protected integrated RC 817c3910e8223fa2ac531a4426ada5d2d4bbbe50; source HEAD: 2c95d0c49d6d04ded18fa39bd4e431b85fa81e67. One isolated change wave, no main/stable/RC mutation.

Root cause

The advisory compare-ci-native-shadow.py previously selected canonical Build ARSAS run by PR head SHA + branch. Two PRs can share head SHA/branch but target different bases and yield distinct synthetic merge trees (e.g. integrated RC #727 and main release proposal #729). A newer run for a different PR can hide the correct source/engine proof and cause a misleading failure/timeout. GitHub run pull_requests[].head.sha can be mutable in old run metadata.

Fix

  • Read exact PR number/head from GitHub Actions GITHUB_EVENT_PATH, validate against CLI SHA/branch and bound file input.
  • Require exact run pull_requests[].number in addition to head SHA, head branch, event/name and existing latest-run/attempt ordering.
  • Require source synthetic merge, engine, ArdIrec, archive hash, test list, and independently built native DLL parity proof exactly as before.
  • Add five offline negative/positive test methods. Existing CI P0 regression step runs the suite.
  • Three paths only: comparator script, its unittest script and docs/audits/CI_P3J_D26_NATIVE_PR_RUN_IDENTITY.md. No workflow, WPF/engine, release/pin/installer or COMTRADE Windows CMake/CTest changes.

Acceptance

DRAFT / DO NOT MERGE without owner required-check approval and exact-commit CI. Canonical Windows Build, independent COMTRADE Windows/native CTest, CI P0 and other relevant workflows must be evaluated at the exact candidate SHA/merge. Never infer physical FAT or deduplication authority from green CI. Preserve independentWindowsCTestRetained=true, deduplicationAuthorized=false, releasePromotionAuthority=false.

Protect PR #757 CI routing, #759 diagnostic, #753–#756 safety, #726/#716 Write, #688 SG7, #732 GUI, #727/#729 RC, and published stable v1.6.42. Parent issue #542 remains open.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T10:08:33.633898Z 2c95d0c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant