Repository navigation
Conversation
|
Material icon alignment is ready for operator review: Draft PR #576 #576 ( |
|
UI coordination: Draft PR #575 #575 now builds on this duplicate-Events fix (#574) and extends Google Material icon consistency across all 8 MainWindow destinations, dynamic center/left Add IED launchers, P2 toolbars and IED-card gear, while retaining the operator's single composite NTP clock+server SVG. Exact HEAD |
|
Disposition: Superseded — redundant historical UI stack milestone, preserved through verified ancestry, not merged to main. Canonical replacement: #649, head Unique delta: remove the double Events glyph from overlapping icon templates. Parent patch inspection: 2 files: P2IndustrialWorkstationUx.cs and OperatorNavigationSingleGlyphM214Tests.cs. All original commits and their tests remain reachable in the descendant's Git history; final UI/packaging semantics must still be checked on authoritative GUI source. No historical design evidence or branches are deleted. Safety: Administrative close only. No change to Follow-up: Do not regress the one-glyph-per-affordance acceptance. Keep #578 open for unfinished secondary-dialog inventory. If later branches alter it, protect accepted behavior through the current GUI/RC acceptance checks rather than restoring obsolete intermediate PRs. |
Screenshot-confirmed visual defect
Operator screenshot shows two icons before Events: legacy checklist (
LucideListChecks) and new operator Event Log (OperatorEventLogIcon).Verified root cause
MainWindow.xamlsupplies one exact operator SVGPathunder the Events button.P2IndustrialWorkstationUx.DecorateMainNavigation()separately decorates that same button with a legacyIconEventsNavContentDataTemplate.LucideListChecksbefore the existing composite content. Existing UI: exact six operator SVG icons with resize-safe navigation #571 icon tests never exercised this second runtime decorator, so this escaped the green build.Fix (two files only)
P2IndustrialWorkstationUxnow uses an idempotentApplyNavigationTemplatefor its five native header destinations. If a button already contains a deliberate WPF SVGPathin aViewbox, the legacy template is not applied (and a prior template is cleared). Otherwise legacy text-only navigation keeps its P2 glyph. Diagnostics alert badge keeps its old triangle; other operator SVG shapes untouched.Boundaries
d7313f11; retains Thread B's newest SG/GoCB/SGCB, scalar MV no-angle, and operator icon shapes.main.Exact-SHA verification checkpoint — 2026-10-15
b725268f322483752432946cc6c952fb084a0b9a, 10/10 GitHub workflows SUCCESS, zero failures.