Skip to content

chore: release main #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −2
Open

chore: release main #1618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .release-please-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
".": "25.20.0",
".": "25.21.0",
"packages/api-explorer": "0.9.80",
"packages/code-editor": "0.1.47",
"packages/extension-api-explorer": "22.21.37",
Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## [25.21.0](https://github.com/looker-open-source/sdk-codegen/compare/sdk-codegen-all-v25.20.0...sdk-codegen-all-v25.21.0) (2025-12-02)


### Features

* **go-sdk:** Automatically refresh expired authentication tokens ([#1608](https://github.com/looker-open-source/sdk-codegen/issues/1608)) ([935dae6](https://github.com/looker-open-source/sdk-codegen/commit/935dae6edeb47bdcad167f3b87167d1701182a24))
Copy link

@gemini-code-assist gemini-code-assist bot Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Regarding the implementation of "Automatically refresh expired authentication tokens", I've reviewed the code in go/rtl/auth.go and have some suggestions for improvement. The current implementation includes manual token refresh logic in the AuthSession.Login() method. This is redundant, as the golang.org/x/oauth2 library's oauth2.Transport already handles token acquisition and refreshing automatically and in a thread-safe manner.

I recommend simplifying the code by removing the manual token management and relying entirely on oauth2.Transport. This would involve:

  1. Removing the Login() and IsActive() methods.
  2. Removing the token, source, and mu fields from the AuthSession struct.
  3. Removing the call to s.Login() at the beginning of the Do() method.

This refactoring will make the code cleaner, less prone to concurrency issues, and more aligned with the standard practices for using the oauth2 library.


## [25.20.0](https://github.com/looker-open-source/sdk-codegen/compare/sdk-codegen-all-v25.18.0...sdk-codegen-all-v25.20.0) (2025-11-05)


Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"license": "MIT",
"name": "sdk-codegen-all",
"version": "25.20.0",
"version": "25.21.0",
"description": "All workspaces for SDK code generation",
"author": "Looker",
"private": true,
Expand Down
Loading