Skip to content

Conversation

@looker-open-source-automation-bot
Copy link
Collaborator

🤖 I have created a release beep boop

sdk-codegen-all: 25.21.0

25.21.0 (2025-12-02)

Features

  • go-sdk: Automatically refresh expired authentication tokens (#1608) (935dae6)

This PR was generated with Release Please. See documentation.

@gemini-code-assist
Copy link

Summary of Changes

Hello @looker-open-source-automation-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request facilitates an automated release of the sdk-codegen-all package, advancing its version to 25.21.0. The release incorporates a significant enhancement for the Go SDK, enabling the automatic refreshing of expired authentication tokens to ensure continuous and secure API interactions.

Highlights

  • Automated Release: This pull request is an automated release generated by Release Please.
  • Version Update: The sdk-codegen-all package has been updated to version 25.21.0.
  • Go SDK Feature: A new feature has been introduced in the Go SDK to automatically refresh expired authentication tokens, enhancing reliability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This release PR for version 25.21.0 introduces a feature for automatically refreshing expired authentication tokens in the Go SDK. My review of the implementation in go/rtl/auth.go found that the manual token refresh logic is redundant, as this functionality is already provided by the golang.org/x/oauth2 library in use. I've added a comment to the CHANGELOG.md with a suggestion to refactor this for simplicity and robustness. The rest of the changes in this PR, which are version bumps and changelog updates, look correct.


### Features

* **go-sdk:** Automatically refresh expired authentication tokens ([#1608](https://github.com/looker-open-source/sdk-codegen/issues/1608)) ([935dae6](https://github.com/looker-open-source/sdk-codegen/commit/935dae6edeb47bdcad167f3b87167d1701182a24))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Regarding the implementation of "Automatically refresh expired authentication tokens", I've reviewed the code in go/rtl/auth.go and have some suggestions for improvement. The current implementation includes manual token refresh logic in the AuthSession.Login() method. This is redundant, as the golang.org/x/oauth2 library's oauth2.Transport already handles token acquisition and refreshing automatically and in a thread-safe manner.

I recommend simplifying the code by removing the manual token management and relying entirely on oauth2.Transport. This would involve:

  1. Removing the Login() and IsActive() methods.
  2. Removing the token, source, and mu fields from the AuthSession struct.
  3. Removing the call to s.Login() at the beginning of the Do() method.

This refactoring will make the code cleaner, less prone to concurrency issues, and more aligned with the standard practices for using the oauth2 library.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

APIX Tests

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 204f2c8.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Codegen Tests

439 tests   400 ✅  37s ⏱️
 19 suites   39 💤
  1 files      0 ❌

Results for commit 204f2c8.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Typescript Tests

  2 files   56 suites   1m 1s ⏱️
208 tests 206 ✅ 2 💤 0 ❌
444 runs  440 ✅ 4 💤 0 ❌

Results for commit 204f2c8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant