-
Notifications
You must be signed in to change notification settings - Fork 198
chore: release main #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: release main #1618
Conversation
Summary of ChangesHello @looker-open-source-automation-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request facilitates an automated release of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This release PR for version 25.21.0 introduces a feature for automatically refreshing expired authentication tokens in the Go SDK. My review of the implementation in go/rtl/auth.go found that the manual token refresh logic is redundant, as this functionality is already provided by the golang.org/x/oauth2 library in use. I've added a comment to the CHANGELOG.md with a suggestion to refactor this for simplicity and robustness. The rest of the changes in this PR, which are version bumps and changelog updates, look correct.
|
|
||
| ### Features | ||
|
|
||
| * **go-sdk:** Automatically refresh expired authentication tokens ([#1608](https://github.com/looker-open-source/sdk-codegen/issues/1608)) ([935dae6](https://github.com/looker-open-source/sdk-codegen/commit/935dae6edeb47bdcad167f3b87167d1701182a24)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the implementation of "Automatically refresh expired authentication tokens", I've reviewed the code in go/rtl/auth.go and have some suggestions for improvement. The current implementation includes manual token refresh logic in the AuthSession.Login() method. This is redundant, as the golang.org/x/oauth2 library's oauth2.Transport already handles token acquisition and refreshing automatically and in a thread-safe manner.
I recommend simplifying the code by removing the manual token management and relying entirely on oauth2.Transport. This would involve:
- Removing the
Login()andIsActive()methods. - Removing the
token,source, andmufields from theAuthSessionstruct. - Removing the call to
s.Login()at the beginning of theDo()method.
This refactoring will make the code cleaner, less prone to concurrency issues, and more aligned with the standard practices for using the oauth2 library.
APIX Tests0 tests 0 ✅ 0s ⏱️ Results for commit 204f2c8. |
Codegen Tests439 tests 400 ✅ 37s ⏱️ Results for commit 204f2c8. |
Typescript Tests 2 files 56 suites 1m 1s ⏱️ Results for commit 204f2c8. |
🤖 I have created a release beep boop
sdk-codegen-all: 25.21.0
25.21.0 (2025-12-02)
Features
This PR was generated with Release Please. See documentation.